Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54326
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1108032109180.5758@whisky>
References: <4E397879.4080007@planetavent.de>
	<CABBJUpf+FPB3uewoPxVyHHj6sWhPdMqXY4Vns-grjgA5BKLdWg@mail.gmail.com>
	<20110803192954.GA8856@joeysmith.com>
	<4E39A974.7080405@planetavent.de>
	<alpine.DEB.2.02.1108032109180.5758@whisky>
Date: Wed, 3 Aug 2011 16:18:53 -0400
Message-ID: <CACpmCxLCoMXmbdWK3sQMbCEg6tDYax7Gwnm_SM=dG1UERvRibw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Nicolai Scheer <scope@planetavent.de>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=bcaec51b15f7bb276d04a99f9248
Subject: Re: [PHP-DEV] BUG 55240 - wrong date creation
From: lonnyk@gmail.com (Lonny Kapelushnik)

--bcaec51b15f7bb276d04a99f9248
Content-Type: text/plain; charset=ISO-8859-1

In the date() function the formats are split up. In date() G is w/o leading
zeros and H is w/ leading zeros.

Why were these (as well as many others) combined and turned into an
either/or for DateTime::createFromFormat?

On Wed, Aug 3, 2011 at 4:10 PM, Derick Rethans <derick@php.net> wrote:

> On Wed, 3 Aug 2011, Nicolai Scheer wrote:
>
> > On 03.08.2011 21:29, Joey Smith wrote:
> > >> 2011/8/4 Nicolai Scheer <scope@planetavent.de>:
> > >>> Hi!
> > >>>
> > >>> Did anyone had the time to review bug 55240
> > >>> (https://bugs.php.net/bug.php?id=55240), yet?
> > >>>
> > >
> > > It definitely appears to be unexpected behaviour - the 'G' format for
> > > hours is "24-hour format without leading zeroes" - so the expectation
> > > would be that 'Gi' parses '800' as '8 hours and 0 minutes'. (Also, I
> > > thought I would point out here that the comments on 'G' and 'H', in
> > > timelib_parse_from_format are backwards here - same with 'g' and 'h'.)
> >
> > Unfortunately, there's nothing I could do about the strings to be parsed
> > (in terms of customer agreement...).
> >
> > "24-hour format without leading zeroes" is exactly what I had expected
> > from the 'G' format as well. "24-hour" somehow implies "not greater than
> > 24". On the other hand "overflow" handling might be expected (and even a
> > good thing to do?).
> >
> > Let's see what others are about to comment on the issue...
> > Personally I'd vote for "fixing" this by limiting the parsed value.
> > Another possibility would be to introduce a new format without the
> > "overflow handling"...
>
> Yes, this needs fixing. I am not sure how easy this is though...
> I've assigned the bug to myself.
>
> cheers,
> Derick
>
> --
> http://derickrethans.nl | http://xdebug.org
> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
> twitter: @derickr and @xdebug
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--bcaec51b15f7bb276d04a99f9248--