Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54265 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 61792 invoked from network); 31 Jul 2011 20:06:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Jul 2011 20:06:09 -0000 Authentication-Results: pb1.pair.com header.from=solar@openwall.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=solar@openwall.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain openwall.com designates 195.42.179.200 as permitted sender) X-PHP-List-Original-Sender: solar@openwall.com X-Host-Fingerprint: 195.42.179.200 mother.openwall.net Received: from [195.42.179.200] ([195.42.179.200:39753] helo=mother.openwall.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 46/85-24421-BA5B53E4 for ; Sun, 31 Jul 2011 16:06:08 -0400 Received: (qmail 10136 invoked from network); 31 Jul 2011 20:05:50 -0000 Received: from localhost (HELO pvt.openwall.com) (127.0.0.1) by localhost with SMTP; 31 Jul 2011 20:05:50 -0000 Received: by pvt.openwall.com (Postfix, from userid 503) id 5D0472FD28; Mon, 1 Aug 2011 00:05:19 +0400 (MSD) Date: Mon, 1 Aug 2011 00:05:19 +0400 To: Pierre Joye Cc: PHP Internals List Message-ID: <20110731200519.GA22414@openwall.com> References: <20110717182616.GA17288@openwall.com> <20110719233714.GA28946@openwall.com> <20110731083159.GA21473@openwall.com> <20110731182016.GA22082@openwall.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Subject: Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2 From: solar@openwall.com (Solar Designer) On Sun, Jul 31, 2011 at 08:56:30PM +0200, Pierre Joye wrote: > It looks like your original patch did not change anything in crypt.c That's correct. I overlooked the need to modify crypt.c initially. I only got to that when adding the extra tests, at which time I also found the incorrect check in 5.4's crypt.c from the upgrade to crypt_blowfish 1.1 a month ago. > I see now the other patch posted on the 20th, I missed it and it > indeed fixes the checks in crypt.c :) I will apply it shortly! Yes, please. Thanks! Alexander