Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54248
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CACQesk44dOv9ThQaanhqHi5eotFAp0XnLvK3Nr1AaUzBN_EOTA@mail.gmail.com>
References: <CABBJUpcstSXVi9qyM=V0BQVATu2ZGZuLrV6VaqoqVf=4JCorzg@mail.gmail.com>
	<CACQesk44dOv9ThQaanhqHi5eotFAp0XnLvK3Nr1AaUzBN_EOTA@mail.gmail.com>
Date: Fri, 29 Jul 2011 17:10:01 +0800
Message-ID: <CABBJUpcE3c1j=8ZfAZ2ZLkJbORfoy9OJugoi2co0d7+wmSHp+g@mail.gmail.com>
To: Etienne Kneuss <colder@php.net>
Cc: PHP Internals <internals@lists.php.net>, Felipe Pena <felipensp@gmail.com>, 
	Pierre Joye <pierre.php@gmail.com>, =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [Bug #55311] Static methods invoke __call when called
 from within class
From: laruence@php.net (Laruence)

Hi:

2011/7/29 Etienne Kneuss <colder@php.net>:
> Hi,
>
> On Fri, Jul 29, 2011 at 05:37, Laruence <laruence@php.net> wrote:
>> Hi:
>> =C2=A0 =C2=A0 about #55311.https://bugs.php.net/bug.php?id=3D55311
>>
>> =C2=A0 =C2=A0 I found it maybe for some reason, that somebody change the
>> if/elseif sequence to make this bug.
>>
>> =C2=A0 =C2=A0 but I am not sure about why he do this, =C2=A0so I refer t=
o maillist, =C2=A0any idea?
>
> This is not a bug.
>
> If you call a method using the Foo::bar() syntax, you don't
> necessarily get a static call.
>
> A static call is made if either:
>
> 1) the target method is declared as static
> 2) There is no compatible object context at the time of the call.

I was wondering does this is well-documented?  since when?

obviously, it is BC break to PHP 5.3.3.

in PHP 5.3.3 __staticCall is in the front of the if/elseif statements.

so I was very interesting to know why this was changed


thanks, ;)

>
> In this case, it is not a static call, as the method is undeclared
> (hence cannot be declared as static) and you do have a compatible
> object context. So __call is used, not __callstatic.
>
> Best,
>
>>
>> =C2=A0 =C2=A0Index: Zend/zend_object_handlers.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- Zend/zend_object_handlers.c (revision 313905)
>> +++ Zend/zend_object_handlers.c (working copy)
>> @@ -988,13 +988,13 @@
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!fbc && zend_hash_find(&ce->function_tabl=
e, lc_function_name,
>> function_name_strlen+1, (void **) &fbc)=3D=3DFAILURE) {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0efree(lc_function=
_name);
>>
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ce->__call &&
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ce->__callstatic)=
 {
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 return zend_get_user_callstatic_function(ce, function_name_strval,
>> function_name_strlen);
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if (ce->__call=
 &&
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0EG(=
This) &&
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Z_O=
BJ_HT_P(EG(This))->get_class_entry &&
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ins=
tanceof_function(Z_OBJCE_P(EG(This)), ce TSRMLS_CC)) {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0return zend_get_user_call_function(ce, function_name_strval,
>> function_name_strlen);
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if (ce->__call=
static) {
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 return zend_get_user_callstatic_function(ce, function_name_strval,
>> function_name_strlen);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0return NULL;
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>> --
>> Laruence =C2=A0Xinchen Hui
>> http://www.laruence.com/
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
>
> --
> Etienne Kneuss
> http://www.colder.ch
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/