Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54239 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37997 invoked from network); 28 Jul 2011 23:10:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jul 2011 23:10:40 -0000 Authentication-Results: pb1.pair.com header.from=owenestea@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=owenestea@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender) X-PHP-List-Original-Sender: owenestea@gmail.com X-Host-Fingerprint: 209.85.161.42 mail-fx0-f42.google.com Received: from [209.85.161.42] ([209.85.161.42:33951] helo=mail-fx0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 68/8F-35879-E6CE13E4 for ; Thu, 28 Jul 2011 19:10:39 -0400 Received: by fxe23 with SMTP id 23so1956298fxe.29 for ; Thu, 28 Jul 2011 16:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=HnE+2E/siXBWaA9kcUqFpB+B3jH2uxgHh46esp6P3Bc=; b=Z+pm3N0m3syhIhhiFAYeHAMO22Dxy+uUOuh8RkKxQwbVINikl6CB0wReY6ITaTvPom HiE6dQUzds6n8ioRjPyQqq5p3ZT8/p0ry4O1M6IhNbQkIN9G8basiJFUwp8r/1fsXGYC a/qNbRR42nG9YXo2YZWQ9WD/EFf2SHBw5e8rM= MIME-Version: 1.0 Received: by 10.204.104.1 with SMTP id m1mr183169bko.162.1311894635919; Thu, 28 Jul 2011 16:10:35 -0700 (PDT) Received: by 10.204.42.4 with HTTP; Thu, 28 Jul 2011 16:10:35 -0700 (PDT) Date: Thu, 28 Jul 2011 16:10:35 -0700 Message-ID: To: internals@lists.php.net Cc: Kiyoto Tamura Content-Type: text/plain; charset=ISO-8859-1 Subject: parsing break and continue statements From: owenestea@gmail.com (Kiyoto Tamura) Hi, I am new to the PHP internals, and I was just looking through the code related to parsing break/continue statements. It looks that as of PHP 5.4, Zend/zend_language_parser.y accepts both "T_BREAK expr" and "T_CONTINUE expr" and check to make sure "expr" is a positive integer in the function zend_do_brk_cont. Doesn't it make more sense to replace "T_BREAK expr" with "T_BREAK " (the same goes for the continue statement)? Thanks in advance! kiyoto