Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54231
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpdKtebJZj9krxC2o1x1-HJO68s_1gq3kP+mV=4BFMaRFg@mail.gmail.com>
References: <CABBJUpc_r1XftvPVfpQcZ_EzbYiV+-kKjdqQArUm0H6UGN2wTQ@mail.gmail.com>
	<alpine.DEB.2.02.1107281157220.29412@whisky>
	<CABBJUpdKtebJZj9krxC2o1x1-HJO68s_1gq3kP+mV=4BFMaRFg@mail.gmail.com>
Date: Thu, 28 Jul 2011 13:41:05 +0200
Message-ID: <CAEZPtU7hUJLJkm0+O0NwaVmkJL_udq00ou+rZsZgp8WnpOn=7w@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: Derick Rethans <derick@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC]strn(case)cmp supporting negative length as third parameter
From: pierre.php@gmail.com (Pierre Joye)

the signature is not the same anymore, some extension may not build
anymore (depending on the compiler used and its flag).

Cheers,

On Thu, Jul 28, 2011 at 1:32 PM, Laruence <laruence@php.net> wrote:
> Hi:
>
> why?
>
> I think this change would not cause any other side-effects.
>
> and if you are worry about INT_MAX, =A0I think it's ok to declare with
> long(in fact, I already did so).
>
> thanks
>
> 2011/7/28 Derick Rethans <derick@php.net>:
>> On Thu, 28 Jul 2011, Laruence wrote:
>>
>>> Hi:
>>>
>>> =A0 strn(case)cmp dosen't =A0support a negative length as its third
>>> paramter, =A0while substr dose.
>>>
>>> =A0I wrote a patch to make strn(case)cmp supporting negative length,
>>> make following script works as expect:
>>>
>>> =A0 =A0 <?php
>>> =A0 =A0if (strncmp("prefix_num", "num", -3) =3D=3D=3D 0) {
>>> =A0 =A0 =A0 =A0 echo "they have same suffix\n";
>>> =A0 =A0}
>>> =A0 ?>
>>>
>>> =A0here is the rfc: https://wiki.php.net/rfc/strncmpnegativelen
>>
>> - You're changing binary API of some API functions, so this can't go
>> =A0into PHP 5.3:
>>
>> =A0 =A0 =A0 =A0-ZEND_API int zend_binary_strncmp(const char *s1, uint le=
n1, const char *s2, uint len2, uint length);
>> =A0 =A0 =A0 =A0+ZEND_API int zend_binary_strncmp(const char *s1, uint le=
n1, const char *s2, uint len2, int length);
>>
>> cheers,
>> Derick
>>
>> --
>> http://derickrethans.nl | http://xdebug.org
>> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
>> twitter: @derickr and @xdebug
>>
>
>
>
> --
> Laruence =A0Xinchen Hui
> http://www.laruence.com/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org