Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54230
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <alpine.DEB.2.02.1107281157220.29412@whisky>
References: <CABBJUpc_r1XftvPVfpQcZ_EzbYiV+-kKjdqQArUm0H6UGN2wTQ@mail.gmail.com>
	<alpine.DEB.2.02.1107281157220.29412@whisky>
Date: Thu, 28 Jul 2011 19:32:46 +0800
Message-ID: <CABBJUpdKtebJZj9krxC2o1x1-HJO68s_1gq3kP+mV=4BFMaRFg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC]strn(case)cmp supporting negative length as third parameter
From: laruence@php.net (Laruence)

Hi:

why?

I think this change would not cause any other side-effects.

and if you are worry about INT_MAX,  I think it's ok to declare with
long(in fact, I already did so).

thanks

2011/7/28 Derick Rethans <derick@php.net>:
> On Thu, 28 Jul 2011, Laruence wrote:
>
>> Hi:
>>
>> =C2=A0 strn(case)cmp dosen't =C2=A0support a negative length as its thir=
d
>> paramter, =C2=A0while substr dose.
>>
>> =C2=A0I wrote a patch to make strn(case)cmp supporting negative length,
>> make following script works as expect:
>>
>> =C2=A0 =C2=A0 <?php
>> =C2=A0 =C2=A0if (strncmp("prefix_num", "num", -3) =3D=3D=3D 0) {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 echo "they have same suffix\n";
>> =C2=A0 =C2=A0}
>> =C2=A0 ?>
>>
>> =C2=A0here is the rfc: https://wiki.php.net/rfc/strncmpnegativelen
>
> - You're changing binary API of some API functions, so this can't go
> =C2=A0into PHP 5.3:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0-ZEND_API int zend_binary_strncmp(const char *=
s1, uint len1, const char *s2, uint len2, uint length);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0+ZEND_API int zend_binary_strncmp(const char *=
s1, uint len1, const char *s2, uint len2, int length);
>
> cheers,
> Derick
>
> --
> http://derickrethans.nl | http://xdebug.org
> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
> twitter: @derickr and @xdebug
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/