Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54218
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <op.vnb0shjiidpuyk@damnation.dulce.lo.geleia.net>
References: <op.vnb0shjiidpuyk@damnation.dulce.lo.geleia.net>
Date: Wed, 27 Jul 2011 02:20:37 +0200
Message-ID: <CAEZPtU7R=6MOKXW7UQ8vFWi1rfYK-=yxywzzfft1GpPKcy=Ksg@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH] Add option to disable POST data processing
From: pierre.php@gmail.com (Pierre Joye)

hi Gustavo,

Could you apply your patch tomorrow please? So we have it for the
alpha3 on Thursday.

Thanks for your work!

Cheers,

On Tue, Dec 7, 2010 at 8:08 AM, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote:
> The very simple attached patch adds an option to disable POST data
> processing, which implies the data can only be read in a stream fashion
> through php://input.
>
> As far as I know, PHP offers no way to inhibit processing RFC 1867 data and
> one has to use very hacky means to accomplish that. This is often required
> (or at least convenient) in order to, e.g., proxy requests or handle file
> uploads in memory.
>
> For other types of requests, the default processing of POST data may also be
> a problem. Take a non-application/x-www-form-urlencoded POST requests (say,
> some kind of RPC with a big XML payload) -- PHP is very memory inefficient
> as it will hold the whole POST data into memory and duplicate it twice (from
> SG(request_info).post_data to $HTTP_RAW_POST_DATA -- even if
> always_populate_raw_post_data=0 -- and SG(request_info).raw_post_data).
>
> This introduces a new ini setting, disable_post_data_processing, but it's a
> benign one. No incompatibilities between setups will arise because no one
> will enable it globally (it would be insane), only selectively to the
> scripts that require it. The reason for an ini setting is that it must be
> set early in the request life.
>
> Thoughts?
>
> --
> Gustavo Lopes
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org