Newsgroups: php.internals,php.qa
Path: news.php.net
Xref: news.php.net php.internals:54178 php.qa:65884
Return-Path: <hannes.magnusson@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 83907 invoked from network); 23 Jul 2011 23:22:03 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Jul 2011 23:22:03 -0000
Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
X-PHP-List-Original-Sender: hannes.magnusson@gmail.com
X-Host-Fingerprint: 209.85.220.170 mail-vx0-f170.google.com  
Received: from [209.85.220.170] ([209.85.220.170:57788] helo=mail-vx0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id CC/54-59700-A975B2E4 for <internals@lists.php.net>; Sat, 23 Jul 2011 19:22:03 -0400
Received: by vxi39 with SMTP id 39so2580086vxi.29
        for <multiple recipients>; Sat, 23 Jul 2011 16:22:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=Iwve0KejyZj5jdjjtVNiux8EeaGmzEcTpcdmBTEKLwg=;
        b=KG6Bm2k95TCIDXfWfXYR8LbGDcx45PXoYAWGAqBBBlnw2oJBoH954npZb9JXsjFl/Q
         3pmS9Cjz09QR7Bz7qMJWbZ5U/bmOW9d4yVwCAt5SK30Xre2GnvX9g2hMTLS2gdSkJJnC
         YdPF6jDifZ52u6aBkidkldn6tynTQAk1sosXk=
MIME-Version: 1.0
Received: by 10.52.155.135 with SMTP id vw7mr2723718vdb.238.1311463319256;
 Sat, 23 Jul 2011 16:21:59 -0700 (PDT)
Received: by 10.52.167.198 with HTTP; Sat, 23 Jul 2011 16:21:59 -0700 (PDT)
In-Reply-To: <CAMWw8k9TxMHkm8SQnKkqu8o5Dt0hsXpV97-CK=nyd-UD6B3P4g@mail.gmail.com>
References: <EEC7B72B6296471D876EE88FC4A85623@pc07654>
	<4E2AF3D4.9070704@daylessday.org>
	<CAKUjMCU6sUqmmH21AFhZcZr+09b9iMxJgjRCEhKqLLWOkM3CKQ@mail.gmail.com>
	<CAMWw8k9A0t62wvZRwp+XAL2pUsvhTWHGExYDwxBhQchbvohUcw@mail.gmail.com>
	<CAEZPtU55pxN-u+d-ceLcHruea5tbed8-3AGtzD6==d3qwW15wQ@mail.gmail.com>
	<CADNQb0VMWNRd2fSnDFn+uH8D4Fk_MMuU8GEfmoZgo03qEMd6PA@mail.gmail.com>
	<CAMWw8k9TxMHkm8SQnKkqu8o5Dt0hsXpV97-CK=nyd-UD6B3P4g@mail.gmail.com>
Date: Sun, 24 Jul 2011 01:21:59 +0200
Message-ID: <CADNQb0Vx=Oq0B-hEJu+NtX3GQO-7YDzzAOiHsVRStxP=rV3sRQ@mail.gmail.com>
To: Gwynne Raskind <gwynne@darkrainfall.org>
Cc: Pierre Joye <pierre.php@gmail.com>, PHP QA <php-qa@lists.php.net>, 
	Olivier DOUCET <odoucet@php.net>, RQuadling@gmail.com, Antony Dovgal <tony@daylessday.org>, 
	internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] new gcov.php.net machine is up
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Sun, Jul 24, 2011 at 01:07, Gwynne Raskind <gwynne@darkrainfall.org> wrote:
> Here's my question - if I made some smaller commits here and there to
> fix warnings in core, would that be accepted? I don't have time to do
> sweeping changes, but fixing one file today, a couple the next day,
> etc., is within my abilities (including making sure no regressions are
> introduced, of course).


Why on earth would anyone complain about such commit from an
already-trusted-person-with-karma?

If you start flooding the commit list with one-liners, people will
probably complain.
But if you are willing to do the extensive work needed to fix several
warnings per commit..

I personally wouldn't commit such patch from 3rd party.
Reverting such commit from a person I trust however wouldn't come to mind.
Cursory review would be all *I* would do.
Can't speak for anyone else...


Fixing these sort of warnings in existing stable releases however IMO
causes more risk then necessary.

-Hannes