Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54099 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 73794 invoked from network); 19 Jul 2011 23:44:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jul 2011 23:44:18 -0000 Authentication-Results: pb1.pair.com header.from=solar@openwall.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=solar@openwall.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain openwall.com designates 195.42.179.200 as permitted sender) X-PHP-List-Original-Sender: solar@openwall.com X-Host-Fingerprint: 195.42.179.200 mother.openwall.net Received: from [195.42.179.200] ([195.42.179.200:42137] helo=mother.openwall.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9A/83-48320-0D6162E4 for ; Tue, 19 Jul 2011 19:44:18 -0400 Received: (qmail 22208 invoked from network); 19 Jul 2011 23:44:14 -0000 Received: from localhost (HELO pvt.openwall.com) (127.0.0.1) by localhost with SMTP; 19 Jul 2011 23:44:14 -0000 Received: by pvt.openwall.com (Postfix, from userid 503) id B0FF22FD2D; Wed, 20 Jul 2011 03:44:06 +0400 (MSD) Date: Wed, 20 Jul 2011 03:44:06 +0400 To: PHP Internals List Message-ID: <20110719234406.GB28946@openwall.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Subject: CRYPT_SHA256 fails tests in trunk From: solar@openwall.com (Solar Designer) Hi, These tests fail in trunk on my x86_64 build: crypt_sha256.phpt crypt_variation1.phpt The differences are like this: Expected: <$5$saltstring$5B8vYYiY.CVt1RlTTf8KbXBH3hsxY/GNooZaBBGWEc5> Got <$5$saltst$JTS/fkywz8NvjeCGmWDndJPi7ZrRFhQKBLNtQZWE2C3> That is, the salts are truncated. There's a relevant recent change in crypt.c involving the line: salt_in_len = MIN(PHP_MAX_SALT_LEN, salt_in_len); I did not investigate this for real - I am merely passing the info that I readily have. I hope this helps. Alexander