Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54095 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64463 invoked from network); 19 Jul 2011 22:56:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jul 2011 22:56:46 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.42 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.218.42 mail-yi0-f42.google.com Received: from [209.85.218.42] ([209.85.218.42:59856] helo=mail-yi0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A3/E1-48320-DAB062E4 for ; Tue, 19 Jul 2011 18:56:45 -0400 Received: by yih10 with SMTP id 10so2183151yih.29 for ; Tue, 19 Jul 2011 15:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=MNH1Y4nq4I16ej6ll9iQ7MDxWjP1lBrKWp+ujIia6UU=; b=hs2EBFc8ASC08P3nqU87jG0z1LzbnC2cbLol4nr8XtJO3FMJeSX3tPb/keZnY0zhq3 ejF8MTaFBo7BNmm9gt5S2t3DpVNshPKC90TvG2eTEhvr1jWdwxrCPqxBeGJxH6HFD4m4 A0l7VNlwINCk1ZDGkJGQAH+eZJ+ZeNLLSjz/E= MIME-Version: 1.0 Received: by 10.236.192.166 with SMTP id i26mr10233233yhn.114.1311116202616; Tue, 19 Jul 2011 15:56:42 -0700 (PDT) Received: by 10.147.34.16 with HTTP; Tue, 19 Jul 2011 15:56:42 -0700 (PDT) In-Reply-To: References: <37923B5A-3A77-47EA-8319-A23D3C1DFE5B@macvicar.net> Date: Wed, 20 Jul 2011 00:56:42 +0200 Message-ID: To: Scott MacVicar Cc: PHP internals Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: Subverting OpenSSL library function with Windows alternatives From: pierre.php@gmail.com (Pierre Joye) and I will restore it myself right now, to be sure that it will be in the next releases. On Wed, Jul 20, 2011 at 12:54 AM, Pierre Joye wrote: > Scott, > > > > On Wed, Jul 20, 2011 at 12:35 AM, Scott MacVicar wro= te: >> Just noticed a commit from Pierre last week http://svn.php.net/viewvc?vi= ew=3Drevision&revision=3D313112 which changed OpenSSL to use a special Wind= ows API call for gathering random data. >> >> I've reverted this change so we can discuss this further. > > There is nothing to discuss. The Windows implementation is just as > safe and is much faster than the OpenSsl API. > >> I disagree with advertising a library function and changing it to use so= mething else. Especially when this is around random data / encryption. The = OpenSSL library has been audited externally, if there is a better alternati= ve then this patch should go upstream rather than being hacked into PHP. > > I disagreed with the initial implementation of this function in the > 1st place, for many reasons that we discussed back then. But you still > applied it. Now I don't want to have windows applications behind yet > again slower because of that and this change greatly improve this > function. So we keep it. > > > Cheers, > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > --=20 Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org