Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53894 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56051 invoked from network); 11 Jul 2011 21:34:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Jul 2011 21:34:42 -0000 Authentication-Results: pb1.pair.com smtp.mail=paul.dixon@durham.ac.uk; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=paul.dixon@durham.ac.uk; sender-id=pass Received-SPF: pass (pb1.pair.com: domain durham.ac.uk designates 129.234.248.1 as permitted sender) X-PHP-List-Original-Sender: paul.dixon@durham.ac.uk X-Host-Fingerprint: 129.234.248.1 hermes1.dur.ac.uk Linux 2.6 Received: from [129.234.248.1] ([129.234.248.1:41929] helo=hermes1.dur.ac.uk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 58/D0-49578-07C6B1E4 for ; Mon, 11 Jul 2011 17:34:41 -0400 Received: from DURMAIL2.mds.ad.dur.ac.uk (durmail2b.dur.ac.uk [10.234.250.7]) by hermes1.dur.ac.uk (8.13.8/8.13.7) with ESMTP id p6BLYNb5025813 for ; Mon, 11 Jul 2011 22:34:27 +0100 Received: from exdurf3.mds.ad.dur.ac.uk ([129.234.251.196]) by DURMAIL2.mds.ad.dur.ac.uk with Microsoft SMTPSVC(6.0.3790.4675); Mon, 11 Jul 2011 22:34:23 +0100 Received: from [192.168.0.110] ([82.39.168.185]) by exdurf3.mds.ad.dur.ac.uk with Microsoft SMTPSVC(6.0.3790.4675); Mon, 11 Jul 2011 22:34:22 +0100 Message-ID: <4E1B6C2B.1020008@durham.ac.uk> Date: Mon, 11 Jul 2011 22:33:31 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 11 Jul 2011 21:34:22.0755 (UTC) FILETIME=[4CB6F730:01CC4012] X-DurhamAcUk-MailScanner-ID: p6BLYNb5025813 X-DurhamAcUk-MailScanner: Found to be clean Subject: Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes From: paul.dixon@durham.ac.uk (Paul Dixon) On 08/07/11 17:28, Richard Quadling wrote: > On 8 July 2011 17:21, DIXON P. wrote: >> Thanks Richard, >> >> Renamed and attached. >> >> -----Original Message----- >> From: Richard Quadling [mailto:rquadling@gmail.com] >> Sent: 08 July 2011 17:13 >> To: DIXON P. >> Cc: internals@lists.php.net >> Subject: Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes >> >> On 8 July 2011 17:10, DIXON P. wrote: >>> Hi, >>> >>> I've attached a patch ... >> Rename as .txt to get through the mailing list s/w. > For consistency, should bits and mime become 4 and 5? > > This would work in the same way as using named capturing in a regex, > where you get both the position index and the name in the result array > and I think various db_fetch_as_array type functions also. > > > It would be trivial to add 4, 5 and 6 for mime, channels and bits respectively, and I can do that if people think that's best. However personally long term, I would aim to remove the position index entries completely. Paul