Newsgroups: php.internals,php.webmaster
Path: news.php.net
Xref: news.php.net php.internals:53893 php.webmaster:11589
Return-Path: <tyra3l@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 53520 invoked from network); 11 Jul 2011 21:23:39 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 11 Jul 2011 21:23:39 -0000
Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.42 as permitted sender)
X-PHP-List-Original-Sender: tyra3l@gmail.com
X-Host-Fingerprint: 74.125.83.42 mail-gw0-f42.google.com  
Received: from [74.125.83.42] ([74.125.83.42:42210] helo=mail-gw0-f42.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 94/70-49578-AD96B1E4 for <internals@lists.php.net>; Mon, 11 Jul 2011 17:23:38 -0400
Received: by gwb17 with SMTP id 17so1919501gwb.29
        for <multiple recipients>; Mon, 11 Jul 2011 14:23:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        bh=l8VhX6PvUOzMfZbFj7vvr5AKYbwcqEkNQLj3EQ5p11k=;
        b=CWalPB4OOB3Sx25TCfbUgsrFPief2+5/SbXZw4swvR9wl9+RDHjFnjEiEh4asDFtol
         6bqVaJnKNH9GATo4dCZiBgGbh7eRBQPqDwDfcdoSUU29JHdKFSLGqhDdSVDuZDzhbTIx
         IrNTJBxOFqblaaaK+qW+UHp8u7rgAEjP3bNiQ=
MIME-Version: 1.0
Received: by 10.236.191.9 with SMTP id f9mr6545541yhn.22.1310419415834; Mon,
 11 Jul 2011 14:23:35 -0700 (PDT)
Received: by 10.147.38.17 with HTTP; Mon, 11 Jul 2011 14:23:33 -0700 (PDT)
In-Reply-To: <CADNQb0XPtkHCAvP3dxm+U9R-AMAYxtgWd6-bKw0mx8C-pDBSLQ@mail.gmail.com>
References: <CAH-PCH40muSZ-9DAXVcRMC0gjQH2b1=CRmcBeL315jFZAwOs2g@mail.gmail.com>
	<4E1AB83A.6060801@sugarcrm.com>
	<CADNQb0Vg6vPg0k0YJ_23_VGfzSiQ70D2_ghJ-ke-SHnazaSa4w@mail.gmail.com>
	<CAEZPtU44LjWusp-+KWhaN50bmVLaAHXmttxOfFy=kyQAyp1Z0Q@mail.gmail.com>
	<CAEZPtU5AZ=14unupawXnwiB0gPYxoLwOFzj-LVHKF4qF+QaZfw@mail.gmail.com>
	<CADNQb0USw0y1jgnWWPkw8H+v73FQ_5HE815qAjBMA-gQ26J2GQ@mail.gmail.com>
	<CADNQb0W6zQTAnf_mwpbo-vLK5bUEzY5UwP_JxYZJvPDO62aAmQ@mail.gmail.com>
	<CAH-PCH4d+qJ35gvSFYGVaoTMSN0jLyAh1+tyLcNZKvBKdMujRg@mail.gmail.com>
	<CAH-PCH5pHJNpYJYZro0yM5xU+LiF=0yVVz1e2muyzgWVfoVAqg@mail.gmail.com>
	<CADNQb0UmSPQPNrVCUe=inb5nGP4kBogZJV49iuP16dox0Fgg0w@mail.gmail.com>
	<CAH-PCH5Fu_3HGVDnrA1+t0TrTkquR801SvGK6f+mKwL+6vgeSA@mail.gmail.com>
	<52B477DE-081D-4ACD-9A14-29514EFFC85D@roshambo.org>
	<CADNQb0Wg6Jgs4uZxMbt8s8=Ev8YTa9dsXzEPmb5QaGienHFGLQ@mail.gmail.com>
	<4E1B49F2.2020304@sugarcrm.com>
	<CAPg3XxKO=7BZdV8qMrc8uC5k8OuTk_P9PEdrGB63qwjgcZMvWQ@mail.gmail.com>
	<CAH-PCH5g7D4GipneCBfmcA6A_6uNeSTme4wR4uba+M5Ps1Wm3A@mail.gmail.com>
	<CADNQb0Wm6gRTTVqN+rqGg4_LdCiBimTZ-x59TNT8Htq-hncoBQ@mail.gmail.com>
	<CAH-PCH7T2HfWJBSxGEmH95nU7-tuEgQ-zGJtxWYS9HjdqukU3A@mail.gmail.com>
	<CADNQb0XPtkHCAvP3dxm+U9R-AMAYxtgWd6-bKw0mx8C-pDBSLQ@mail.gmail.com>
Date: Mon, 11 Jul 2011 23:23:33 +0200
Message-ID: <CAH-PCH6TR2D0yQ9yTdEO-xjQF_YtQCrwXKfhvzW9AOe9rTzAbQ@mail.gmail.com>
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: Peter Cowburn <petercowburn@gmail.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Philip Olson <philip@roshambo.org>, Pierre Joye <pierre.php@gmail.com>, 
	php-webmaster <php-webmaster@lists.php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] sudden spike in wiki registrations
From: tyra3l@gmail.com (Ferenc Kovacs)

On Mon, Jul 11, 2011 at 11:09 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> On Mon, Jul 11, 2011 at 22:13, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>>> Stas means when we print who has voted, to only print votes by people
>>> in that group so you won't need to manually filter out
>>> not-allowed-to-vote votes.
>>>
>>> -Hannes
>>>
>>
>> I see.
>> if you only need the @php.net usernames, you can use the
>> https://master.php.net/fetch/allusers.php api with the proper token,
>> or https://bugs.php.net/js/userlisting.php without it.
>
> Or just ask the internal wiki api if the username is in the phpcvs/voted =
group.
> No need to make it complicated.

oh, I didn't though of that, as this is how my patch works (albeit
only for the new votes, but still). :)

>
> The whole idea of this sort of workaround is however very silly to me.

thanks for sharing, this kind of comments which keeps me contributing ;)

ps:

"The current vote still needs to be reviewed manually anyway, so I
really don't understand the need for a quick hack at this time.
Cooperating with the plugin authors on how to implement better checks
there would imo make much more sense."

I did this because it seems that some people use the current situation
(that technically anybody can vote) as a cannon fodder for some
personal arguments.
the patch is as clean as it can be, and I asked you and others to
review it before applying.
of course the plugin author could do a better job, feel free to revert
mine if we ever got that.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu