Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53834
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E1AA582.1070201@sugarcrm.com>
References: <CAEZPtU7WJNjgpuFPh6Kmww-nbXu6BQ_1wD4pZFgK7xxrYW3bjw@mail.gmail.com>
	<1310072926.3298.32.camel@guybrush>
	<4E171A47.9010609@smashlabs.com>
	<4E1AA3B7.7050907@zend.com>
	<4E1AA582.1070201@sugarcrm.com>
Date: Mon, 11 Jul 2011 10:17:27 +0200
Message-ID: <CADNQb0VEFr=xH7hEwqpMjDB-XP=SbH8OF_G1Cv-YB_21KDYPhw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Dmitry Stogov <dmitry@zend.com>, Ralph Schindler <ralph@smashlabs.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS
 branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt
 branches/PHP_5_3/Zend/zend_builtin_functions.c branches/PHP_5_3/ext/standard/tests/class_object/is_a_
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Mon, Jul 11, 2011 at 09:25, Stas Malyshev <smalyshev@sugarcrm.com> wrote=
:
> Hi!
>
> On 7/11/11 12:18 AM, Dmitry Stogov wrote:
>>
>> Hi Ralph,
>>
>> I don't have strong opinion about your suggestion.
>>
>> In some cases this warning might help to find a typo, in others it may
>> be useless, but anyway, I think that usage of undefined class name is a
>> quite rare situation. I would prefer to keep it as is.
>
> It's not as rare, if people use is_a the same way as instanceof. Example
> I've seen recently - suppose you've got a method that receives either
> instance of an object or it's ID, something like this:
>
> function process($obj)
> {
> =C2=A0if(!is_a($obj, "MyClass") {
> =C2=A0 =C2=A0 $obj =3D new MyClass($obj);
> =C2=A0}
> =C2=A0// process $obj
> }
>
> Here you've got a new warning. Of course, you could do just $obj instance=
of
> MyClass, but it's a very subtle distinction which many people miss. So th=
e
> thing here is not that $obj has unknown class name - it's not even a clas=
s
> name at all.

Isn't this exactly why is_a() was un-deprecated in the firstplace?

Getting warnings from is_a() would be very weird.

-Hannes