Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53830 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65705 invoked from network); 11 Jul 2011 07:18:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Jul 2011 07:18:30 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.199.177.89 il-mr1.zend.com Received: from [212.199.177.89] ([212.199.177.89:50285] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0A/13-41672-1C3AA1E4 for ; Mon, 11 Jul 2011 03:18:26 -0400 Received: from il-gw1.zend.com (unknown [10.1.1.22]) by il-mr1.zend.com (Postfix) with ESMTP id A527F60715; Mon, 11 Jul 2011 10:17:15 +0300 (IDT) Received: from tpl2.home (10.1.10.4) by il-ex2.zend.net (10.1.1.22) with Microsoft SMTP Server id 14.1.255.0; Mon, 11 Jul 2011 10:18:10 +0300 Message-ID: <4E1AA3B7.7050907@zend.com> Date: Mon, 11 Jul 2011 11:18:15 +0400 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Ralph Schindler CC: , =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= , Stas Malyshev References: <1310072926.3298.32.camel@guybrush> <4E171A47.9010609@smashlabs.com> In-Reply-To: <4E171A47.9010609@smashlabs.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Originating-IP: [10.1.10.4] Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functions.c branches/PHP_5_3/ext/standard/tests/class_object/is_a_ From: dmitry@zend.com (Dmitry Stogov) Hi Ralph, I don't have strong opinion about your suggestion. In some cases this warning might help to find a typo, in others it may=20 be useless, but anyway, I think that usage of undefined class name is a=20 quite rare situation. I would prefer to keep it as is. Thanks. Dmitry. On 07/08/2011 06:55 PM, Ralph Schindler wrote: > Oh by all means, kill the warning. The behavior is sound though (the fi= x > for the issue reported in #53727 where a missing parent *ce would affec= t > the is_a_impl()'s ability to correctly determine it's subtype. > > The question is, should we keep the warning in 5.4? I'd say no, I think > false should suffice b/c it answers the question correctly: "Is > NonExistentClass a subclass of SomeOtherClass": no. In that case, > there's no real need for a warning. > > Patch for 5.3 attached, and should probably be applied to trunk and 5.4 > as well if you think that is the right idea. > > -ralph > > On 7/7/11 4:08 PM, Johannes Schl=C3=BCter wrote: >> On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote: >>> what kind of troubles do they see? >> >> https://pear.php.net/bugs/bug.php?id=3D18656 >> >> Even if the Warning is good it's questionable for 5.3, especially duri= ng >> RC. >> (note that warnings not only cause the error being reported, which can >> be switched off and fill logfiles but also triggers error handlers whi= ch >> won't expect this ...) >> >> johannes >> >>> 2011/7/7 Johannes Schl=C3=BCter: >>>> Hi, >>>> >>>> I was told (didn't verify) that this causes lots of trouble with PEA= R >>>> and other applications. We're in final RC phase of 5.3.7. I don't th= ink >>>> it is critical for 5.3.7 and I wonder whether we need it for 5.3 at >>>> all. >>>> >>>> johannes >>>> >>>> On Mon, 2011-07-04 at 14:55 +0000, Dmitry Stogov wrote: >>>>> dmitry Mon, 04 Jul 2011 14:55:39 +0000 >>>>> >>>>> Revision: http://svn.php.net/viewvc?view=3Drevision&revision=3D3129= 04 >>>>> >>>>> Log: >>>>> Fixed bug #53727 (Inconsistent behavior of is_subclass_of with >>>>> interfaces) >>>>> >>>>> Bug: https://bugs.php.net/53727 (Assigned) Inconsistent behavior of >>>>> is_subclass_of with interfaces >>>>> >>>>> Changed paths: >>>>> U php/php-src/branches/PHP_5_3/NEWS >>>>> A php/php-src/branches/PHP_5_3/Zend/tests/bug53727.phpt >>>>> U php/php-src/branches/PHP_5_3/Zend/tests/is_a.phpt >>>>> U php/php-src/branches/PHP_5_3/Zend/zend_builtin_functions.c >>>>> U >>>>> php/php-src/branches/PHP_5_3/ext/standard/tests/class_object/is_a_v= ariation_001.phpt >>>>> >>>>> A php/php-src/branches/PHP_5_4/Zend/tests/bug53727.phpt >>>>> U php/php-src/branches/PHP_5_4/Zend/tests/is_a.phpt >>>>> U php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c >>>>> U >>>>> php/php-src/branches/PHP_5_4/ext/standard/tests/class_object/is_a_v= ariation_001.phpt >>>>> >>>>> A php/php-src/trunk/Zend/tests/bug53727.phpt >>>>> U php/php-src/trunk/Zend/tests/is_a.phpt >>>>> U php/php-src/trunk/Zend/zend_builtin_functions.c >>>>> U >>>>> php/php-src/trunk/ext/standard/tests/class_object/is_a_variation_00= 1.phpt >>>>> >>>>> >>>>> -- >>>>> PHP CVS Mailing List (http://www.php.net/) >>>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>>> >>>> >>>> -- >>>> PHP Internals - PHP Runtime Development Mailing List >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>>> >>> >>> >>> >> >> >> >