Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53785 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70090 invoked from network); 8 Jul 2011 14:55:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jul 2011 14:55:11 -0000 Authentication-Results: pb1.pair.com header.from=ralph@smashlabs.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ralph@smashlabs.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain smashlabs.com from 67.15.58.61 cause and error) X-PHP-List-Original-Sender: ralph@smashlabs.com X-Host-Fingerprint: 67.15.58.61 openrce.org Linux 2.6 Received: from [67.15.58.61] ([67.15.58.61:34292] helo=users.smashlabs.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DA/43-48961-B4A171E4 for ; Fri, 08 Jul 2011 10:55:08 -0400 Received: (qmail 22267 invoked from network); 8 Jul 2011 09:54:46 -0500 Received: from ip174-73-14-247.no.no.cox.net (HELO ralph-macbook.local) (174.73.14.247) by smashlabs.com with (DHE-RSA-AES256-SHA encrypted) SMTP; 8 Jul 2011 09:54:46 -0500 Message-ID: <4E171A47.9010609@smashlabs.com> Date: Fri, 08 Jul 2011 09:55:03 -0500 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666 MIME-Version: 1.0 To: internals@lists.php.net CC: Dmitry Stogov , =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= , Stas Malyshev References: <1310072926.3298.32.camel@guybrush> In-Reply-To: <1310072926.3298.32.camel@guybrush> Content-Type: multipart/mixed; boundary="------------000206020407040305090909" Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functions.c branches/PHP_5_3/ext/standard/tests/class_object/is_a_ From: ralph@smashlabs.com (Ralph Schindler) --------------000206020407040305090909 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Oh by all means, kill the warning. The behavior is sound though (the fix for the issue reported in #53727 where a missing parent *ce would affect the is_a_impl()'s ability to correctly determine it's subtype. The question is, should we keep the warning in 5.4? I'd say no, I think false should suffice b/c it answers the question correctly: "Is NonExistentClass a subclass of SomeOtherClass": no. In that case, there's no real need for a warning. Patch for 5.3 attached, and should probably be applied to trunk and 5.4 as well if you think that is the right idea. -ralph On 7/7/11 4:08 PM, Johannes Schlüter wrote: > On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote: >> what kind of troubles do they see? > > https://pear.php.net/bugs/bug.php?id=18656 > > Even if the Warning is good it's questionable for 5.3, especially during > RC. > (note that warnings not only cause the error being reported, which can > be switched off and fill logfiles but also triggers error handlers which > won't expect this ...) > > johannes > >> 2011/7/7 Johannes Schlüter: >>> Hi, >>> >>> I was told (didn't verify) that this causes lots of trouble with PEAR >>> and other applications. We're in final RC phase of 5.3.7. I don't think >>> it is critical for 5.3.7 and I wonder whether we need it for 5.3 at all. >>> >>> johannes >>> >>> On Mon, 2011-07-04 at 14:55 +0000, Dmitry Stogov wrote: >>>> dmitry Mon, 04 Jul 2011 14:55:39 +0000 >>>> >>>> Revision: http://svn.php.net/viewvc?view=revision&revision=312904 >>>> >>>> Log: >>>> Fixed bug #53727 (Inconsistent behavior of is_subclass_of with interfaces) >>>> >>>> Bug: https://bugs.php.net/53727 (Assigned) Inconsistent behavior of is_subclass_of with interfaces >>>> >>>> Changed paths: >>>> U php/php-src/branches/PHP_5_3/NEWS >>>> A php/php-src/branches/PHP_5_3/Zend/tests/bug53727.phpt >>>> U php/php-src/branches/PHP_5_3/Zend/tests/is_a.phpt >>>> U php/php-src/branches/PHP_5_3/Zend/zend_builtin_functions.c >>>> U php/php-src/branches/PHP_5_3/ext/standard/tests/class_object/is_a_variation_001.phpt >>>> A php/php-src/branches/PHP_5_4/Zend/tests/bug53727.phpt >>>> U php/php-src/branches/PHP_5_4/Zend/tests/is_a.phpt >>>> U php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c >>>> U php/php-src/branches/PHP_5_4/ext/standard/tests/class_object/is_a_variation_001.phpt >>>> A php/php-src/trunk/Zend/tests/bug53727.phpt >>>> U php/php-src/trunk/Zend/tests/is_a.phpt >>>> U php/php-src/trunk/Zend/zend_builtin_functions.c >>>> U php/php-src/trunk/ext/standard/tests/class_object/is_a_variation_001.phpt >>>> >>>> -- >>>> PHP CVS Mailing List (http://www.php.net/) >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >>> >>> -- >>> PHP Internals - PHP Runtime Development Mailing List >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >> >> >> > > > --------------000206020407040305090909 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="remove-warning-in-is_a_impl.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="remove-warning-in-is_a_impl.diff" ZGlmZiAtLWdpdCBhL1plbmQvemVuZF9idWlsdGluX2Z1bmN0aW9ucy5jIGIvWmVuZC96ZW5k X2J1aWx0aW5fZnVuY3Rpb25zLmMKaW5kZXggZDAyNzYwOS4uNjAyNTZiMyAxMDA2NDQKLS0t IGEvWmVuZC96ZW5kX2J1aWx0aW5fZnVuY3Rpb25zLmMKKysrIGIvWmVuZC96ZW5kX2J1aWx0 aW5fZnVuY3Rpb25zLmMKQEAgLTgyNSw3ICs4MjUsNiBAQCBzdGF0aWMgdm9pZCBpc19hX2lt cGwoSU5URVJOQUxfRlVOQ1RJT05fUEFSQU1FVEVSUywgemVuZF9ib29sIG9ubHlfc3ViY2xh c3MpCiAJaWYgKFpfVFlQRV9QKG9iaikgPT0gSVNfU1RSSU5HKSB7CiAJCXplbmRfY2xhc3Nf ZW50cnkgKip0aGVfY2U7CiAJCWlmICh6ZW5kX2xvb2t1cF9jbGFzcyhaX1NUUlZBTF9QKG9i aiksIFpfU1RSTEVOX1Aob2JqKSwgJnRoZV9jZSBUU1JNTFNfQ0MpID09IEZBSUxVUkUpIHsK LQkJCXplbmRfZXJyb3IoRV9XQVJOSU5HLCAiVW5rbm93biBjbGFzcyBwYXNzZWQgYXMgcGFy YW1ldGVyIik7CiAJCQlSRVRVUk5fRkFMU0U7CiAJCX0KIAkJaW5zdGFuY2VfY2UgPSAqdGhl X2NlOwo= --------------000206020407040305090909--