Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53772
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpdCr8S3ciphLOBrnXoxLMdBqN9SppXxCAJ3EZOdKjUB5Q@mail.gmail.com>
References: <CABBJUpdt-gL49tZg3LfPO+rUc+_roJ=ApKPKebFJESim9BrH1Q@mail.gmail.com>
	<CADNQb0XcUYMmHRzaVLHt2oH4WBAwD5gMXHFMOV__UYHbE=AZ8w@mail.gmail.com>
	<4E145FE2.5000001@php.net>
	<CABBJUpdCr8S3ciphLOBrnXoxLMdBqN9SppXxCAJ3EZOdKjUB5Q@mail.gmail.com>
Date: Thu, 7 Jul 2011 17:50:27 +0200
Message-ID: <CAF+90c8maSpp5VhtRCEv_eU8pfRTREEDm5+u1=Pd=3pfa2eBpQ@mail.gmail.com>
To: Xinchen Hui <laruence@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=0023543a27ee05dcaf04a77cada9
Subject: Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token
From: nikita.ppv@googlemail.com (Nikita Popov)

--0023543a27ee05dcaf04a77cada9
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

+1 for adding this.

I don't know enough C to review the patches. The first one looks fine thoug=
h
at first glance (apart from some CS *nits probably, like duplicate
parenthesis and usage of if {} else { if {} else {}} instead of if {} elsei=
f
{} else {}).

Your second patch (the one for adding the silence operator) though seems
strange. For example you are calling zend_do_begin_silence regardless of
whether '@' was used, don't you?


On Wed, Jul 6, 2011 at 3:33 PM, Xinchen Hui <laruence@gmail.com> wrote:

> Hi:
>
>  first of all, I am a guy whose english is poor, sorry for making you
> confuse.
>
>  the feature request is here: https://bugs.php.net/bug.php?id=3D10203
>
>  and I think this can make php code more flexible, and more making sense.
>
>  example:
>
>  foreach (array(
>       array(3, array(1, 2)),
>       array(7, array(3, 4)),
>      ) as list($sum, list($op1, $op2))) {
>        printf("%d + %d  =3D %d\n", $op1, $op2, $sum);
>  }
>
>  output:
>  1 + 2  =3D 3
>  3 + 4  =3D 7
>
>  plz read the RFC for more details.
>
> thanks
>
> 2011/7/6 Stefan Neufeind <neufeind@php.net>:
> > Hi,
> >
> > On 07/06/2011 03:06 PM, Hannes Magnusson wrote:
> >> 2011/7/6 Xinchen Hui <laruence@gmail.com>:
> >>>
> >>>   T_LIST is not allowed to used with foreach before.
> >>>
> >>>   and then there comes a freature request:  #10203  allow
> >>> foreach($array as list($a,$b)
> >>
> >> Ironically enough you managed to miss the last closing ), enforcing
> >> the point of this not being a natural syntax.
> >>
> >> Furthermore, without reading the RFC, is this the same as
> >> foreach($array as $a =3D> $b) {}
> >
> > No, there $a would be the key. Intention would be, as I read the RFC,
> > that this could be an arbitrary list.
> >
> >> or
> >> foreach($array as $e) {
> >> list($a, $b) =3D $e;
> >> }
> >
> > Yes, I understood if like that. Just a short notation.
> >
> >> or.. ?
> >>
> >> that really doesn't look like something PHP should support imo.
> >
> > Don't see too many bad things about the idea ...
> >
> >
> > Regards,
> >  Stefan
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>
>
>
> --
> =E6=83=A0=E6=96=B0=E5=AE=B8        laruence
> Senior PHP Engineer
> http://www.laruence.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--0023543a27ee05dcaf04a77cada9--