Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53738
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGSj+QvxZC8Ruze7Jj4-m=A=yS0Qb5TzLRJnd6afSvCKJCg6eg@mail.gmail.com>
References: <CAML1Pf7z1xYL1FGxv9Lb0pq3B=oy0DDSKE3nLQgu2zn-q-Ce-Q@mail.gmail.com>
	<4E10D453.9060606@daylessday.org>
	<CAGSj+QvxZC8Ruze7Jj4-m=A=yS0Qb5TzLRJnd6afSvCKJCg6eg@mail.gmail.com>
Date: Sun, 3 Jul 2011 14:07:39 -0700
Message-ID: <CAKa35F6rrYOcOAMEZ04ik8OHwfBxytnFif5c3SZEKmXYwiX+dw@mail.gmail.com>
To: Kiall Mac Innes <kiall@managedit.ie>
Cc: Antony Dovgal <tony@daylessday.org>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Big patch for FPM (config and initialization)
From: mike503@gmail.com (Michael Shadle)

+1 the way for change is to add the new, add an E_DEPRECATED style
warning for a point release or two, and then nix it.

On Sun, Jul 3, 2011 at 2:04 PM, Kiall Mac Innes <kiall@managedit.ie> wrote:
> FPM is still new, and only just getting the experimental flag removed, now
> is the only time to make any BC breaking cosmitic changes that will lead to
> less confusion in the long run..
>
> That said - I'm not sure about the diagnostics group name..
>
> Maybe allow for both the old and new naming on 5.4 and remove the old in
> 5.next...?
>
> Kiall
> On Jul 3, 2011 9:43 p.m., "Antony Dovgal" <tony@daylessday.org> wrote:
>> On 07/03/2011 04:50 AM, Giovanni Giacobbi wrote:
>>> Detailed changelog of the patch:
>>> - Renamed options "pm.status_path", "ping.path", "ping.response" into
>>> a new logical group "diagnostics", so they are now respectively:
>>> "diagnostics.status_path", "diagnostics.ping_path",
>>> "diagnostics.ping_response".
>>
>> I'm not quite sure renaming config options would help anybody, in my
> opinion it would do more harm than good.
>> I personally would certainly expect my existing config files to continue
> to work after upgrade to 5_4.
>> Yes, we're changing '3' to '4' in the version number, but that doesn't
> mean we can just go ahead and break the config file.
>>
>> Other than that, looks ok to me (assuming you've tested it and does
> continue to work the way it worked before all those cosmetic changes).
>>
>> --
>> Wbr,
>> Antony Dovgal
>> ---
>> http://pinba.org - realtime profiling for PHP
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>