Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53730
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <CAFK6my6QjzA-eRqzz0kXkTdKmNbDGk8+c5vOcw2Q9qDB0LS7WA@mail.gmail.com>
Date: Sun, 03 Jul 2011 02:27:16 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: Quoted-Printable
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_IST?=
Message-ID: <op.vx0rnqtaidpuyk@cataphract.cata.lo.geleia.net>
In-Reply-To: <CAFK6my6QjzA-eRqzz0kXkTdKmNbDGk8+c5vOcw2Q9qDB0LS7WA@mail.gmail.com>
User-Agent: Opera Mail/11.50 (Win32)
Subject: Re: [PHP-DEV] Compilation warning on offsetof in 5.4 and trunk
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Sun, 03 Jul 2011 02:07:48 +0100, J=C3=A9r=C3=B4me Loyet <jerome@loyet=
.net> wrote:

>
> the warnings appear in sapis (cgi, fpm, ...) and extensions (standard,=

> ...) and the problem comes from the XOffsetOf macro which is expanded
> to offsetof defined in Zend/zend_operators.h whit the following code
> added in revisions 311662 and 312264:
>
> #ifndef offsetof
> #define offsetof(t,f) \
>   ((int)(&((t*)0)->f))
> #endif
>

Yes, the cast should be changed to (size_t)(uintptr_t).

I have also hit this problem a month ago. At the time I think I commente=
d  =

on IRC using (int)(intptr_t) instead could avoid problems like in "if  =

(offsetof(x) - 5 < 0)", but since the C standard calls for a =C2=ABexpan=
d[ing]  =

to an integer constant expression that has type size_t=C2=BB,  =

(size_t)(uintptr_t) seems preferable.

-- =

Gustavo Lopes