Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53714
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain seancoates.com from 64.15.79.181 cause and error)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=windows-1252
In-Reply-To: <4E0CE015.80503@no-surprises.co.uk>
Date: Thu, 30 Jun 2011 20:55:17 -0400
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <3D0839B3-5201-4D8C-9539-E4FBEC81C038@seancoates.com>
References: <4E0CE015.80503@no-surprises.co.uk>
To: Michael Maclean <michael@no-surprises.co.uk>
Subject: Re: [PHP-DEV] Improvements to HTTP stream metadata
From: sean@seancoates.com (Sean Coates)

> * Add a 'response_code' key, with the server response code as an =
integer
> =85
> Anyone got any thoughts on this? I appreciate it'd be a BC break, but =
I think it might be useful.

While I applaud the idea of making this easier, keep in mind that a =
single request can have multiple status code responses:

<?php
$s =3D fopen('http://gimmebar.com/', 'r');
$m =3D stream_get_meta_data($s);
var_dump(array_filter($m['wrapper_data'], function ($l) {
	if (substr($l, 0, 5) =3D=3D=3D 'HTTP/') {
		return true;
	}
}));

Outputs:
array(2) {
  [0]=3D>
  string(18) "HTTP/1.1 302 Found"
  [8]=3D>
  string(15) "HTTP/1.1 200 OK"
}

There could also be a large number of "HTTP/1.1 100 Continue" headers in =
there, or more 300 series redirects.
Putting the headers into an associative array also has similar problems =
(there can be many headers with the same name).
This can, of course, be worked around, but it's not as simple as just =
expecting a single response code from a HTTP stream request.=20

Aside, but related: most code I'd written prior to ~6 months ago, and =
most of the example code I've seen does something like:
list($prot, $status, $msg) =3D explode($m['wrapper_data'][0], 3);
=85which is a nasty bug to track down.

S