Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53703 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21963 invoked from network); 30 Jun 2011 12:47:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Jun 2011 12:47:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.213.170 mail-yx0-f170.google.com Received: from [209.85.213.170] ([209.85.213.170:35854] helo=mail-yx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C8/20-20472-B407C0E4 for ; Thu, 30 Jun 2011 08:47:08 -0400 Received: by yxk8 with SMTP id 8so998456yxk.29 for ; Thu, 30 Jun 2011 05:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=TFb4wfm1XVuZWq04BZBPHb1cj1zdamymMufaZihDSWc=; b=AdWb3Lbq49FV5xbEcTGonz8Ew3cz084uBMDpabWdJpGpLfgo3mh+nPw/9rI++Dopx7 aRnHCcPrppAW+L+ye29hoduYlXXDkxmpyRBA18xyh0f8EQ1fFwMz7MBCSjKSxXliLVvB uivlpnrhdy5ZUKcqTfWjM7ZvAvtexfP7Sod9I= MIME-Version: 1.0 Received: by 10.236.154.5 with SMTP id g5mr264355yhk.198.1309438024776; Thu, 30 Jun 2011 05:47:04 -0700 (PDT) Received: by 10.147.167.16 with HTTP; Thu, 30 Jun 2011 05:47:04 -0700 (PDT) In-Reply-To: <1309431260.2984.2.camel@guybrush> References: <1309303149.2331.119.camel@guybrush> <1309431260.2984.2.camel@guybrush> Date: Thu, 30 Jun 2011 14:47:04 +0200 Message-ID: To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= Cc: =?ISO-8859-1?Q?David_Z=FClke?= , Arpad Ray , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [PATCH] Friendly log messages for CLI server From: pierre.php@gmail.com (Pierre Joye) agreed, it should be optional and off by default. PHP never had such feature either. 2011/6/30 Johannes Schl=FCter : > On Thu, 2011-06-30 at 07:08 +0200, David Z=FClke wrote: >> On 29.06.2011, at 01:19, Johannes Schl=FCter wrote: >> >> > On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote: >> >> - Colours messages according to their response code (success=3Dgreen, >> >> client error=3Dyellow, server error=3Dred) >> > >> > I would prefer if this would be an ini option (if (cli_web_server.colo= r >> > && isatty) color =3D true) default can be on, but I've seen cases wher= e >> > such magic failed and created hard-to use results (due to control >> > sequences in log files or such). >> >> The code could detect if it's outputting to a TTY or not and only use >> color codes if the output isn't redirected somewhere else. > > It *is* checking this. And I showed an example (script(1)) where the > environment pretends to be a TTY and isn't. My suggestion was to add an > ini option in addition to the check. > > johannes > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org