Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53702
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
Reply-To: RQuadling@GMail.com
In-Reply-To: <alpine.DEB.2.02.1106301223480.3774@whisky>
References: <BANLkTikqzmiXHhJUb2m2=1RYtr_niPTGQA@mail.gmail.com>
 <1309303149.2331.119.camel@guybrush> <D93F2F76-B8CD-48C9-BBB7-A29BF29FB5A7@bitextender.com>
 <1309431260.2984.2.camel@guybrush> <alpine.DEB.2.02.1106301223480.3774@whisky>
Date: Thu, 30 Jun 2011 13:31:58 +0100
Message-ID: <BANLkTin6hrNX1Hu9=5Y5bmwoveCCiTqqbg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	=?UTF-8?B?RGF2aWQgWsO8bGtl?= <david.zuelke@bitextender.com>, 
	Arpad Ray <arraypad@gmail.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] Friendly log messages for CLI server
From: rquadling@gmail.com (Richard Quadling)

On 30 June 2011 12:24, Derick Rethans <derick@php.net> wrote:
> On Thu, 30 Jun 2011, Johannes Schl=C3=BCter wrote:
>
>> On Thu, 2011-06-30 at 07:08 +0200, David Z=C3=BClke wrote:
>> > On 29.06.2011, at 01:19, Johannes Schl=C3=BCter wrote:
>> >
>> > > On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote:
>> > >> - Colours messages according to their response code (success=3Dgree=
n,
>> > >> client error=3Dyellow, server error=3Dred)
>> > >
>> > > I would prefer if this would be an ini option (if (cli_web_server.co=
lor
>> > > && isatty) color =3D true) default can be on, but I've seen cases wh=
ere
>> > > such magic failed and created hard-to use results (due to control
>> > > sequences in log files or such).
>> >
>> > The code could detect if it's outputting to a TTY or not and only use
>> > color codes if the output isn't redirected somewhere else.
>>
>> It *is* checking this. And I showed an example (script(1)) where the
>> environment pretends to be a TTY and isn't. My suggestion was to add an
>> ini option in addition to the check.
>
> I'm fine with that, but let's leave it set to 1 by default? People with
> complex requirements can then turn it off if they want to.
>
> regards,
> Derick
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

In Windows, there is no default colouring support at the console, so
it would make sense if it was off by default.

I use a tool called ANSICon which provides the colouring support
(http://en.wikipedia.org/wiki/ANSI_escape_code#Support and source+bins
at http://adoxa.110mb.com/ansicon/).

So, for me turning it on would work for me.

Richard.

--=20
Richard Quadling
Twitter : EE : Zend : PHPDoc
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea