Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53700
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: David =?ISO-8859-1?Q?Z=FClke?= <david.zuelke@bitextender.com>
Cc: Arpad Ray <arraypad@gmail.com>, internals@lists.php.net
In-Reply-To: <D93F2F76-B8CD-48C9-BBB7-A29BF29FB5A7@bitextender.com>
References: <BANLkTikqzmiXHhJUb2m2=1RYtr_niPTGQA@mail.gmail.com>
	 <1309303149.2331.119.camel@guybrush>
	 <D93F2F76-B8CD-48C9-BBB7-A29BF29FB5A7@bitextender.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 30 Jun 2011 12:54:20 +0200
Message-ID: <1309431260.2984.2.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Friendly log messages for CLI server
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Thu, 2011-06-30 at 07:08 +0200, David Zülke wrote:
> On 29.06.2011, at 01:19, Johannes Schlüter wrote:
> 
> > On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote:
> >> - Colours messages according to their response code (success=green,
> >> client error=yellow, server error=red)
> > 
> > I would prefer if this would be an ini option (if (cli_web_server.color
> > && isatty) color = true) default can be on, but I've seen cases where
> > such magic failed and created hard-to use results (due to control
> > sequences in log files or such).
> 
> The code could detect if it's outputting to a TTY or not and only use
> color codes if the output isn't redirected somewhere else.

It *is* checking this. And I showed an example (script(1)) where the
environment pretends to be a TTY and isn't. My suggestion was to add an
ini option in addition to the check.

johannes