Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53697
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender)
Message-ID: <4E0C284B.1050601@zend.com>
Date: Thu, 30 Jun 2011 11:39:55 +0400
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10
MIME-Version: 1.0
To: Ralph Schindler <ralph@smashlabs.com>
CC: internals <internals@lists.php.net>, <david.zuelke@bitextender.com>
References: <4E0B7F82.5080006@smashlabs.com>
In-Reply-To: <4E0B7F82.5080006@smashlabs.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: Fix for #53727 (is_subclass_of resolution with interfaces)
From: dmitry@zend.com (Dmitry Stogov)

Hi Ralph,

I agree with expected behavior, but didn't understand the patch and 
which side effects it may have as well as the original implementation of 
is_a_impl(). It looks for me like one huge bug :)

Please reassign the bug to me, if you like me to take a deeper look.
I can do it only on next week.

Thanks. Dmitry.

On 06/29/2011 11:39 PM, Ralph Schindler wrote:
> Hi all,
>
> Concerning: https://bugs.php.net/bug.php?id=53727
>
> I had put together a quick patch against PHP_5_3 to fix, for what I and
> others might consider, an issue with is_subclass_of() returning false in
> this situation:
>
> interface A {}
> class B implements A {}
> var_dump(is_subclass_of('B', 'A')); // false, should be true
>
> It returns false in situations where a class does not have a parent. If
> a parent currently exists, the above works fine. For example:
>
> interface A {}
> class B implements A {}
> class C extends B {}
> var_dump(is_subclass_of('B', 'A')); // true
>
> Attached is a patch against PHP_5_3, I can create a patch against
> PHP_5_4 if need be.
>
> I've added a test file and all the current Zend/tests run as expected.
>
> Thanks,
> Ralph