Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53650
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Derick Rethans <derick@php.net>
Cc: =?ISO-8859-1?Q?J=E9r=F4me?= Loyet <jerome@loyet.net>, Arpad Ray
 <arraypad@gmail.com>, internals@lists.php.net
In-Reply-To: <alpine.DEB.2.02.1106291144330.3774@whisky>
References: <BANLkTikqzmiXHhJUb2m2=1RYtr_niPTGQA@mail.gmail.com>
	 <1309303149.2331.119.camel@guybrush>
	 <BANLkTin6A5XW5Scm+aneH-6mppaPFiXRRQ@mail.gmail.com>
	 <alpine.DEB.2.02.1106291144330.3774@whisky>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 29 Jun 2011 13:07:37 +0200
Message-ID: <1309345657.3741.21.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Friendly log messages for CLI server
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Wed, 2011-06-29 at 11:45 +0100, Derick Rethans wrote:
> That's why the patch first checks whether stdout is actually a tty, so 
> your log file will not have ansi control characters.

While that check is not always the best/good thing. For instance if
you're using script(1) to log a terminal session you will end up with a
log file with control sequences.

Script started on June 29, 2011 12:59:59 PM CEST
$ cat test.c
#include <unistd.h>

int main() {
        printf("%i\n", isatty(STDOUT_FILENO));
        return 0;
}
       
$ gcc -otest test.c
$ ./test
1
$ exit
script done on June 29, 2011 01:02:11 PM CEST

And then there are people using "strange" backgrounds or have trouble
identifying specific colors - so I think it should be made optional.

johannes