Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53649 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76488 invoked from network); 29 Jun 2011 10:45:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Jun 2011 10:45:05 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:59972] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F2/01-05351-0320B0E4 for ; Wed, 29 Jun 2011 06:45:04 -0400 Received: from localhost (xdebug.org [127.0.0.1]) by xdebug.org (Postfix) with ESMTPS id 7005710D287; Wed, 29 Jun 2011 11:45:01 +0100 (BST) Date: Wed, 29 Jun 2011 11:45:01 +0100 (BST) X-X-Sender: derick@whisky To: =?UTF-8?Q?J=C3=A9r=C3=B4me_Loyet?= cc: =?UTF-8?Q?Johannes_Schl=C3=BCter?= , Arpad Ray , internals@lists.php.net In-Reply-To: Message-ID: References: <1309303149.2331.119.camel@guybrush> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1695225526-1309344301=:3774" Subject: Re: [PHP-DEV] [PATCH] Friendly log messages for CLI server From: derick@php.net (Derick Rethans) --8323328-1695225526-1309344301=:3774 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 29 Jun 2011, J=C3=A9r=C3=B4me Loyet wrote: > 2011/6/29 Johannes Schl=C3=BCter : > > On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote: > >> - Colours messages according to their response code (success=3Dgreen, > >> client error=3Dyellow, server error=3Dred) > > > > I would prefer if this would be an ini option (if (cli_web_server.color > > && isatty) color =3D true) default can be on, but I've seen cases where > > such magic failed and created hard-to use results (due to control > > sequences in log files or such). > > >=20 > I agree with johannes. Color should be an option, all term does not > handle them correctly. Also, color control sequences are just killing > a log file. That's why the patch first checks whether stdout is actually a tty, so=20 your log file will not have ansi control characters. Derick --8323328-1695225526-1309344301=:3774--