Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53644
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain oracle.com from 148.87.113.121 cause and error)
Message-ID: <4E0A6456.70600@oracle.com>
Date: Tue, 28 Jun 2011 16:31:34 -0700
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7
MIME-Version: 1.0
To: internals@lists.php.net
References: <BANLkTikqzmiXHhJUb2m2=1RYtr_niPTGQA@mail.gmail.com> <1309303149.2331.119.camel@guybrush>
In-Reply-To: <1309303149.2331.119.camel@guybrush>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Friendly log messages for CLI server
From: christopher.jones@oracle.com (Christopher Jones)



On 06/28/2011 04:19 PM, Johannes Schlüter wrote:
> On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote:
>> - Colours messages according to their response code (success=green,
>> client error=yellow, server error=red)
>
> I would prefer if this would be an ini option (if (cli_web_server.color
> &&  isatty) color = true) default can be on, but I've seen cases where
> such magic failed and created hard-to use results (due to control
> sequences in log files or such).
>
> johannes
>
>
>

I'm -1 on the color coding for a few reasons: (i) it can be done
outside of PHP (ii) forcing a particular color coding is problematic
for many users (iii) the escape codes are not portable.

The other items in the patch have merit.

If you're looking at the web server code, perhaps you can sort out the
issues with subdirectories and include()?  Moriyoshi has gone quiet
on it.

Chris

-- 
Email: christopher.jones@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/