Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53591 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56064 invoked from network); 27 Jun 2011 00:00:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2011 00:00:32 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 207.97.245.143 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 207.97.245.143 smtp143.iad.emailsrvr.com Linux 2.6 Received: from [207.97.245.143] ([207.97.245.143:46322] helo=smtp143.iad.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8E/00-01045-028C70E4 for ; Sun, 26 Jun 2011 20:00:32 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp24.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id B1D011A01FB; Sun, 26 Jun 2011 20:00:27 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp24.relay.iad1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 57E631A01B6; Sun, 26 Jun 2011 20:00:26 -0400 (EDT) Message-ID: <4E07C819.5050003@sugarcrm.com> Date: Sun, 26 Jun 2011 17:00:25 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= CC: Pierre Joye , Rasmus Lerdorf , PHP internals References: <4E06EF9A.4030603@lerdorf.com> <4E07A696.2090602@sugarcrm.com> <1309131363.6053.38.camel@guybrush> In-Reply-To: <1309131363.6053.38.camel@guybrush> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] todo: crypt_blowfish issue From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! On 6/26/11 4:36 PM, Johannes Schlüter wrote: > If the hash changes everybody who stored encrypted passwords or such > using the old format can't verify them anymore. The change will be only for 8-bit data though. > My suggestion without looking really deep into these things: Change the > default, and an "old_blowfish" for compatibility and advertise it ... > not sure it's the best thing. We could add some flag, etc. to it to trigger the old behavior - it needs to pass 1 as the last parameter to BF_set_key then. That would probably require some modifications to crypt_blowfish.c as currently php_crypt_blowfish_rn uses the salt to determine the algorithm. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227