Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5356 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34652 invoked by uid 1010); 11 Nov 2003 22:20:05 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 34618 invoked from network); 11 Nov 2003 22:20:04 -0000 Received: from unknown (HELO dns10.mail.yahoo.co.jp) (210.81.151.143) by pb1.pair.com with SMTP; 11 Nov 2003 22:20:04 -0000 Received: from unknown (HELO pana) (219.180.130.35 with poptime) by dns10.mail.yahoo.co.jp with SMTP; 11 Nov 2003 22:20:03 -0000 X-Apparently-From: Date: Wed, 12 Nov 2003 07:20:17 +0900 To: Joe Orton Cc: hirokawa@php.net, internals@lists.php.net Message-ID: <20031112072017.18f598ee.rui_hirokawa@ybb.ne.jp> In-Reply-To: <20031111154535.GA19166@redhat.com> References: <20031111154535.GA19166@redhat.com> X-Mailer: Sylpheed version 0.9.6claws71 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mbstring warning fixes From: rui_hirokawa@ybb.ne.jp (Rui Hirokawa) Thank you for sending patch. I applied your first patch to cvs, but, the second change was already applied in cvs. Rui On Tue, 11 Nov 2003 15:45:35 +0000 Joe Orton wrote: > 4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_converter': > 4.3/ext/mbstring/mbstring.c:3729: warning: `ret' might be used uninitialized in this function > 4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_detector': > 4.3/ext/mbstring/mbstring.c:3792: warning: `encoding' might be used uninitialized in this function > > I'm not sure what the right fixes are here, e.g. below makes the > warnings go away... > > Index: ext/mbstring/mbstring.c > =================================================================== > RCS file: /repository/php-src/ext/mbstring/mbstring.c,v > retrieving revision 1.142.2.37 > diff -u -r1.142.2.37 mbstring.c > --- ext/mbstring/mbstring.c 6 Nov 2003 15:41:36 -0000 1.142.2.37 > +++ ext/mbstring/mbstring.c 11 Nov 2003 15:41:27 -0000 > @@ -3726,7 +3726,7 @@ > TSRMLS_DC) > { > int i; > - mbfl_string string, result, *ret; > + mbfl_string string, result, *ret = NULL; > enum mbfl_no_encoding from_encoding, to_encoding; > mbfl_buffer_converter *convd; > > @@ -3789,7 +3789,7 @@ > { > mbfl_string string; > enum mbfl_no_encoding *elist; > - enum mbfl_no_encoding encoding; > + enum mbfl_no_encoding encoding = mbfl_no_encoding_invalid; > mbfl_encoding_detector *identd = NULL; > > int size, *list; -- Rui Hirokawa