Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53543
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=KQlAU/2YqvUQMrhAmqWa/CQf4odc7DNZgbT2uskEXHXkUPEQ2xHi3r7daeiLfPUi9S
         +2X7S+6/efuviaM9ocj8WLRc05PJkK5iCej6Rh/5oJMvOnsQNn6VFq93X3ZqxB5R2UQm
         Ez/r0t0SoCXt9iv6nBKSixS/lwxb/qrkuhIx8=
MIME-Version: 1.0
In-Reply-To: <4E0382EC.10309@seld.be>
References: <BANLkTimOZPjAu_mJSctXPL3x41QUekFtkw@mail.gmail.com>
	<BANLkTimUN1fqfZGai6cYG7sK=HHYFh72fw@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A492D09D2@il-ex2.zend.net>
	<4DD2A731.9000400@sugarcrm.com>
	<op.vvn44ha0idpuyk@clk-0081.clk-domain>
	<BANLkTikUukoA_FYZ5rDR_iftwe7gu_LHqA@mail.gmail.com>
	<4E0382EC.10309@seld.be>
Date: Thu, 23 Jun 2011 19:21:20 +0100
Message-ID: <BANLkTi=Z0NCR_uEiEFqNdVNt3_dH2SJDYQ@mail.gmail.com>
To: Jordi Boggiano <j.boggiano@seld.be>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=90e6ba6e8edad6f67604a665265a
Subject: Re: [PHP-DEV] Re: [RFC] Improved parser error message
From: dragoonis@gmail.com (Paul Dragoonis)

--90e6ba6e8edad6f67604a665265a
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Jun 23, 2011 at 7:16 PM, Jordi Boggiano <j.boggiano@seld.be> wrote:

> Thanks for the great work. More should be done on the front of helping
> newcomers solve trivial issues imo.
>
> On 23.06.2011 20:08, Felipe Pena wrote:
> > $ sapi/cli/php -r 'class '
> > Current:
> > Parse error: syntax error, unexpected $end, expecting T_STRING
> >
> > Patched:
> > Parse error: syntax error, unexpected end of file, expecting
> > 'identifier' (T_STRING)
>
> identifier should not be quoted. The quotes are fine for "expecting '{'"
> and "unexpected 'foo'" because those are text literals, but this implies
> you were supposed to actually type "class identifier", which is
> obviously not the intended message.
>
> > $ sapi/cli/php -r 'class abc foo'
> > Current:
> > Parse error: syntax error, unexpected T_STRING, expecting '{' in
> > Command line code on line 1
> >
> > Patched:
> > Parse error: syntax error, unexpected 'foo' (T_STRING), expecting '{'
> > in Command line code on line 1
> >
> >
> > As can be noticed, I added the actual scanned string in the
> > "unexpected" part. This might be useful for finding really which makes
> > the parser error. (It was a bit tricky though :D)
>
> Good stuff, maybe "unexpected string 'foo' (T_STRING)" or "unexpected
> string (T_STRING) 'foo'" would be more clear, but no big deal really.
>
> Cheers
>
> --
> Jordi Boggiano
> @seldaek - http://nelm.io/jordi
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

 Good work Felipe! the $end was very ambiguous :-)

--90e6ba6e8edad6f67604a665265a--