Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:53542 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 84623 invoked from network); 23 Jun 2011 18:17:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jun 2011 18:17:05 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.153 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.153 smtp153.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.153] ([67.192.241.153:38455] helo=smtp153.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 76/71-09437-E13830E4 for ; Thu, 23 Jun 2011 14:17:03 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp5.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 6A585585B1; Thu, 23 Jun 2011 14:17:00 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp5.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 1B9F458174; Thu, 23 Jun 2011 14:17:00 -0400 (EDT) Message-ID: <4E03831B.8050200@sugarcrm.com> Date: Thu, 23 Jun 2011 11:16:59 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Felipe Pena CC: "internals@lists.php.net" References: <887FE7CFF6F8DE4BB3A9535F53AFD06A492D09D2@il-ex2.zend.net> <4DD2A731.9000400@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: [RFC] Improved parser error message From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! On 6/23/11 11:08 AM, Felipe Pena wrote: > As can be noticed, I added the actual scanned string in the > "unexpected" part. This might be useful for finding really which makes > the parser error. (It was a bit tricky though :D) > > > Any thoughts? > https://wiki.php.net/rfc/improved-parser-error-message Looks cool. Any tests we'd need to fix for that? Except for that, I think it's all good. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227