Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53540
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=iAP1TBzXUdWcEyYxD5eTOv/whXrf6FUj+1W25+f8IzyHs0QhAcThcPJVZp4wWXKf92
         5nIPGUwsPXgEfZpaH12Pfkk6cnh2RuquI3+8pglVu+99TFWK9um8FGjtyrnHF1s4UhsJ
         L+bDpINg1zTqbMJtMrTHcECImZgBQVvs/8Ogc=
MIME-Version: 1.0
In-Reply-To: <op.vvn44ha0idpuyk@clk-0081.clk-domain>
References: <BANLkTimOZPjAu_mJSctXPL3x41QUekFtkw@mail.gmail.com>
 <BANLkTimUN1fqfZGai6cYG7sK=HHYFh72fw@mail.gmail.com> <887FE7CFF6F8DE4BB3A9535F53AFD06A492D09D2@il-ex2.zend.net>
 <4DD2A731.9000400@sugarcrm.com> <op.vvn44ha0idpuyk@clk-0081.clk-domain>
Date: Thu, 23 Jun 2011 15:08:59 -0300
Message-ID: <BANLkTikUukoA_FYZ5rDR_iftwe7gu_LHqA@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: [RFC] Improved parser error message
From: felipensp@gmail.com (Felipe Pena)

2011/5/18 Gustavo Lopes <glopes@nebm.ist.utl.pt>:
> Em Tue, 17 May 2011 17:49:53 +0100, Stas Malyshev <smalyshev@sugarcrm.com>
> escreveu:
>
>> I think we need to keep token name in the message, since it makes it
>> easier to understand what parser expected if you need to debug the parser
>> (as opposed to your code). So I think we need to have both the
>> human-readable name and the token name, as Andi suggested.
>
> I think this alternative has very little value for debugging the parser.
> There are no repeated labels for the tokens, so even if you don't know the
> token name by heart, you can look it up in 10 seconds.
>
> Keeping the token name will only perpetuate the confusion it has caused. I
> think it ought to be dropped, but if no consensus can be reached, this would
> be better than the status quo.
>
> --
> Gustavo Lopes
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

So, following some suggestion I made a patch wich displays such messages:


$ sapi/cli/php -r 'class '
Current:
Parse error: syntax error, unexpected $end, expecting T_STRING

Patched:
Parse error: syntax error, unexpected end of file, expecting
'identifier' (T_STRING)

$ sapi/cli/php -r 'class abc foo'
Current:
Parse error: syntax error, unexpected T_STRING, expecting '{' in
Command line code on line 1

Patched:
Parse error: syntax error, unexpected 'foo' (T_STRING), expecting '{'
in Command line code on line 1


As can be noticed, I added the actual scanned string in the
"unexpected" part. This might be useful for finding really which makes
the parser error. (It was a bit tricky though :D)


Any thoughts?
https://wiki.php.net/rfc/improved-parser-error-message

-- 
Regards,
Felipe Pena