Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53497
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain seld.be designates 209.85.214.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1106211155070.3774@whisky>
References: <BANLkTikFgkmuQP1kLfCefAXxgGizn9BxZw@mail.gmail.com>
	<4DFF7C28.30100@sugarcrm.com>
	<alpine.DEB.2.02.1106211155070.3774@whisky>
Date: Wed, 22 Jun 2011 02:14:06 +0200
Message-ID: <BANLkTinpcApxrcMwBZ+j-6zNOgfg46PKSw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Robert Eisele <robert@xarg.org>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Changed behaviour for strtr()
From: j.boggiano@seld.be (Jordi Boggiano)

On Tue, Jun 21, 2011 at 12:55 PM, Derick Rethans <derick@php.net> wrote:
> On Mon, 20 Jun 2011, Stas Malyshev wrote:
>
>> > Here is the next one.
>> >
>> > I think it's quite intuitive to use strtr() to remove single characters of a
>> > string, too, instead of using many str_replace($str, $chr, ""). I'd glad to
>> > see this change also in 5.4.
>>
>> This is a BC break, if I understand it correctly, so I don't think it is a
>> good idea.
>
> I agree that this is not a good thing then.

Right now strtr('anything', 'anything', '') === 'anything', which
means that anyone relying on this behavior is doing something strange
and dumb imo, doing a function call for nothing. We could maybe say
that strtr('anything', 'anything', null) maps all letters to an empty
string? That should take care of the user-based inputs for BC reasons,
while still allowing strtr() to be used for this "strip letter x and
y" use case.

Anyway I'm not gonna fight one way or the other, it's a detail, but I
don't think the BC concern is as big as it's presented.

Cheers

-- 
Jordi Boggiano
@seldaek :: http://seld.be/