Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53476
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=kwfRkBz/xhqMzEjqAz/bNw27b6uJ5BKhfLZT4P0CJQT8zZCbH+jBXjGIyZCO2HrSe2
         Vkt92n35EDlchP4QUs2nQ2c8H2BCODYmh1YOoTLL2vlUEOl0A+XUZ9efklu08WcYp/Gg
         /DVexag63i/UmcTYkpTvIjiiTJy8e8DASJ5Jw=
MIME-Version: 1.0
In-Reply-To: <BANLkTinFA2VDD0LmRu2naNp7j9Xq2QXaQw@mail.gmail.com>
References: <4DFA7EDF.5050802@sugarcrm.com> <BANLkTinKnxk=1zeUCNKV4vOTJFVN_uUsxw@mail.gmail.com>
 <BANLkTikUoUE7HYBxuZzZTTY79J7c+sDCJg@mail.gmail.com> <alpine.DEB.2.02.1106201647250.3774@whisky>
 <BANLkTikt9JVy+T1QxuUAm8Cqa2TE+yBxzg@mail.gmail.com> <4E000D33.60400@php.net> <BANLkTinFA2VDD0LmRu2naNp7j9Xq2QXaQw@mail.gmail.com>
Date: Tue, 21 Jun 2011 08:13:39 -0300
Message-ID: <BANLkTinV8xVYdGcFseMtftACHEX70iSDkQ@mail.gmail.com>
To: Etienne Kneuss <colder@php.net>
Cc: Rasmus Lerdorf <systems@php.net>, Derick Rethans <derick@php.net>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] 5.4 features for vote (long)
From: felipensp@gmail.com (Felipe Pena)

2011/6/21 Etienne Kneuss <colder@php.net>:
> Hello,
>
> On Tue, Jun 21, 2011 at 05:17, Rasmus Lerdorf <systems@php.net> wrote:
>> On 06/20/2011 08:09 PM, Felipe Pena wrote:
>>
>>> I'm ok with this, I just think it's ugly to repeat the token name in
>>> the definition in the .y file. :P
>>>
>>> %token T_LNUMBER "'number' (T_LNUMBER)"
>>> %token T_STRING "'identifier' (T_STRING)"
>>
>> Why 'identifier' and not 'string' or 'string-literal' there?
>
> For people using php, a string or a string literal is "foo" or 'foo'.
> T_STRING does not represent "foo" nor 'foo'.
> identifier seems to adequatly describe what it encompass.
>
> IMHO, it would even be better if the unnexpect part displayed the
> actual content:
>
> i.e.
>
> function 1() => Unexpected number '1' ...
> or
> function 1() => Unexpected '1'...
>

Currently it's possible to do this, it'll only require a static
variable in yytnamerr implementation.

-- 
Regards,
Felipe Pena