Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53456
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=cNrrgZnpA212aiBY2quPzgEtiffs96lx6R2bZoeiwKeWgb8KBpm7QsXfxqiwIPeCYP
         fHgSr9mibeSqCD0BANauR+muQzGdhuG3kXs6ITYF92zr/jT4eVE+EAXCn0u0uX5AqGL8
         Es54F6ePF7be1Pu3ZQvWdZyi+w8ot9xU44Qas=
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1106201647250.3774@whisky>
References: <4DFA7EDF.5050802@sugarcrm.com> <BANLkTinKnxk=1zeUCNKV4vOTJFVN_uUsxw@mail.gmail.com>
 <BANLkTikUoUE7HYBxuZzZTTY79J7c+sDCJg@mail.gmail.com> <alpine.DEB.2.02.1106201647250.3774@whisky>
Date: Tue, 21 Jun 2011 00:09:37 -0300
Message-ID: <BANLkTikt9JVy+T1QxuUAm8Cqa2TE+yBxzg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Etienne Kneuss <colder@php.net>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] 5.4 features for vote (long)
From: felipensp@gmail.com (Felipe Pena)

2011/6/20 Derick Rethans <derick@php.net>
>
> On Mon, 20 Jun 2011, Felipe Pena wrote:
>
> > 2011/6/20 Etienne Kneuss <colder@php.net>
> > >
> > > I'd love to see the proposal from Felipe about the improved parse
> > > errors in that list. I believe that the patch was ready or almost
> > > ready? I can't find the RFC though, but maybe the RFC never existed..=
.
> > >
> >
> > https://wiki.php.net/rfc/improved-parser-error-message
>
> I think this is good and helpful.
> I've two suggestions though:
>
> - Add the token name in parenthesis at the end of the string
> - Add '' around the token strings
>
> Examples:
> =C2=A0Parse error: syntax error, unexpected '<<=3D' (T_SL_EQUAL) in Comma=
nd line code on line 1
> =C2=A0Parse error: syntax error, unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM)=
 in Command line code on line 1
> =C2=A0Parse error: syntax error, unexpected 'quoted-string' (T_CONSTANT_E=
NCAPSED_STRING), expecting identifier or '(' in Command line code on line 1
>

To have the quoting message working as desired, we need to implement
the yytnamerr function (based in the default one)
e.g.:

static YYSIZE_T zend_yytnamerr(char *yyres, const char *yystr)
{
	if (!yyres) {
		return yystrlen(yystr);
	}
=09
	if (*yystr =3D=3D '"') {
		YYSIZE_T yyn =3D 0;
		char const *yyp =3D yystr;

		while (1) {
			if (*++yyp !=3D '"') {
				yyres[yyn++] =3D *yyp;
			} else {
				yyres[yyn] =3D '\0';			=09
				return yyn;
			}
		}
	}
	return yystpcpy (yyres, yystr) - yyres;
}

I'm ok with this, I just think it's ugly to repeat the token name in
the definition in the .y file. :P

%token T_LNUMBER "'number' (T_LNUMBER)"
%token T_STRING "'identifier' (T_STRING)"

$ sapi/cli/php -r 'function 1'
Parse error: syntax error, unexpected 'number' (T_LNUMBER), expecting
'identifier' (T_STRING) or '(' in Command line code on line 1

--
Regards,
Felipe Pena