Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53453
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=xP5NFq5mE68lyld7jQKDkTCc+y5rElGidyLmyH6BhDTJpbEAanrERTC+XptbBn9gqM
         XaFWc1Kilf/X2//XWBRFN0/yFElZW7twGcJlvWJTXQFXoKA7UKm0xTmPx7UHGCXyS5Pm
         yc7/yW9szuhSPV33a0D097yxs5WhgekmzUms8=
MIME-Version: 1.0
In-Reply-To: <00df75ce7b1c7095eecfcd9f419908c6@localhost>
References: <BANLkTi=4fkchuWO9_zfYeEkao54X1Lo0=w@mail.gmail.com>
	<1308569847.3172.18.camel@guybrush>
	<BANLkTikbMX1LxSsmY=KbrQ7CfzV80pFYXw@mail.gmail.com>
	<00df75ce7b1c7095eecfcd9f419908c6@localhost>
Date: Mon, 20 Jun 2011 22:41:42 +0100
Message-ID: <BANLkTimB-8ecq6Wimj-Y6DZ+ToUO3pCMGw@mail.gmail.com>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] unregister_shutdown_function()
From: arraypad@gmail.com (Arpad Ray)

2011/6/20 Johannes Schl=FCter <johannes@schlueters.de>:
>
> (any reason you sent this privately?)

Nope, must have hit the wrong button ;) back to the list now.

>
> On Mon, 20 Jun 2011 18:38:50 +0100, Arpad Ray <arraypad@gmail.com> wrote:
>> 2011/6/20 Johannes Schl=FCter <johannes@schlueters.de>:
>>> Why do you register a shutdown function if you want to remove it again?
>>> Shouldn't you fix the architecture of your code instead of relying on
>>> such functions?
>>>
>>
>> Hi,
>>
>> The use case for this function is where you don't control the
>> registration of the shutdown function and you want to remove it, for
>> example the framework you're using does it.
>
> Then fix the framework or use a better one.

I'm inclined to agree, just providing an implementation. If it's not wanted=
, ok.

>
>>> Does register_shutdown_function() work with closures? (Didn't test it)
>>> Then the following should work, too, which isn't the case in your code:
>>>
>>> =A0 =A0$a =3D function() {};
>>> =A0 =A0register_shutdown_function($a);
>>> =A0 =A0unregister_shutdown_function($a);
>>>
>>
>> Thanks for pointing this out, I've updated it to support closures,
>> which also simplifies the patch a bit:
>
> Good.
>
>>
> http://spellign.com/patches/php-trunk-unregister_shutdown_function2.patch
>>
>>> I also think once that functionality is there the next request will be
>>>
>>> =A0 =A0get_registered_shutdown_functions()
>>>
>>> or something along the lines.
>>
>> I don't see of what use that could be.
>
> Completeness? "Has that stupid shutdown func been registered?"

Fair enough, although I should point out that
unregister_shutdown_function() returns false if the function hadn't
been registered, so if the aim of checking whether it's registered is
to remove it then that's unnecessary.

Regards,

Arpad