Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5339 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71824 invoked by uid 1010); 11 Nov 2003 15:45:38 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 71790 invoked from network); 11 Nov 2003 15:45:38 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 11 Nov 2003 15:45:38 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hABFjcM18994; Tue, 11 Nov 2003 10:45:38 -0500 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hABFjb624917; Tue, 11 Nov 2003 10:45:37 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by lacrosse.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hABFjbO31136; Tue, 11 Nov 2003 10:45:37 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id hABFjang020956; Tue, 11 Nov 2003 15:45:36 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id hABFjZsY020955; Tue, 11 Nov 2003 15:45:35 GMT Date: Tue, 11 Nov 2003 15:45:35 +0000 To: hirokawa@php.net, internals@lists.php.net Message-ID: <20031111154535.GA19166@redhat.com> Mail-Followup-To: hirokawa@php.net, internals@lists.php.net Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] mbstring warning fixes From: jorton@redhat.com (Joe Orton) 4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_converter': 4.3/ext/mbstring/mbstring.c:3729: warning: `ret' might be used uninitialized in this function 4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_detector': 4.3/ext/mbstring/mbstring.c:3792: warning: `encoding' might be used uninitialized in this function I'm not sure what the right fixes are here, e.g. below makes the warnings go away... Index: ext/mbstring/mbstring.c =================================================================== RCS file: /repository/php-src/ext/mbstring/mbstring.c,v retrieving revision 1.142.2.37 diff -u -r1.142.2.37 mbstring.c --- ext/mbstring/mbstring.c 6 Nov 2003 15:41:36 -0000 1.142.2.37 +++ ext/mbstring/mbstring.c 11 Nov 2003 15:41:27 -0000 @@ -3726,7 +3726,7 @@ TSRMLS_DC) { int i; - mbfl_string string, result, *ret; + mbfl_string string, result, *ret = NULL; enum mbfl_no_encoding from_encoding, to_encoding; mbfl_buffer_converter *convd; @@ -3789,7 +3789,7 @@ { mbfl_string string; enum mbfl_no_encoding *elist; - enum mbfl_no_encoding encoding; + enum mbfl_no_encoding encoding = mbfl_no_encoding_invalid; mbfl_encoding_detector *identd = NULL; int size, *list;