Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53355
Return-Path: <derick@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 53938 invoked from network); 17 Jun 2011 16:54:20 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Jun 2011 16:54:20 -0000
Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
X-PHP-List-Original-Sender: derick@php.net
X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6
Received: from [82.113.146.227] ([82.113.146.227:39021] helo=xdebug.org)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 22/70-49199-BB68BFD4 for <internals@lists.php.net>; Fri, 17 Jun 2011 12:54:19 -0400
Received: from localhost (xdebug.org [127.0.0.1])
	by xdebug.org (Postfix) with ESMTPS id 1CE39DE13E;
	Fri, 17 Jun 2011 17:54:16 +0100 (BST)
Date: Fri, 17 Jun 2011 17:54:16 +0100 (BST)
X-X-Sender: derick@whisky
To: Stas Malyshev <smalyshev@sugarcrm.com>
cc: "RQuadling@GMail.com" <RQuadling@GMail.com>, 
    PHP Internals <internals@lists.php.net>
In-Reply-To: <alpine.DEB.2.02.1106171613330.4180@whisky>
Message-ID: <alpine.DEB.2.02.1106171753340.4180@whisky>
References: <4DFA96ED.90800@sugarcrm.com> <BANLkTinO3dy+CKnFECLsQtH9YPGwAjsGGw@mail.gmail.com> <4DFB6C69.4040702@sugarcrm.com> <alpine.DEB.2.02.1106171613330.4180@whisky>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] date_diff broken?
From: derick@php.net (Derick Rethans)

On Fri, 17 Jun 2011, Derick Rethans wrote:

> On Fri, 17 Jun 2011, Stas Malyshev wrote:
> 
> > > If either of the dates use a TLA timezone (EDT, PST, GMT), rather 
> > > than the long name (Europe/London, Indian/Kerguelen, 
> > > America/Kentucky/Louisville), then that date is altered.
> > 
> > Yes, this seems to be because TLA ones rely on ->z and ->dst which get 
> > reset in timelib_unixtime2gmt() while other one relies on tzinfo which 
> > is kept intact.
> 
> Yup. I'm fixing it right now.

Done... I had to do it by making a backup for now. It should be looked 
at again though, and I've added that to my (long) todo list.

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug