Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53351
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:reply-to:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type:content-transfer-encoding;
        b=duFvP3iZ21kbKcg60COJQePxck1VdWBufDo44zpZAapJC3AQpnc60kOlkWe2cNjzEA
         qtz+KklCTTtRUn9oYL/Tbo/EmkxEYVrzt6ftyiLr2Mt/mgb6lK1N3oUuCjIStqCKpFn3
         DuYjWjVX9m4jcfn0JsXNHdeM5JN4tqSvTALyI=
MIME-Version: 1.0
Reply-To: RQuadling@GMail.com
In-Reply-To: <4DFA96ED.90800@sugarcrm.com>
References: <4DFA96ED.90800@sugarcrm.com>
Date: Fri, 17 Jun 2011 10:18:26 +0100
Message-ID: <BANLkTinO3dy+CKnFECLsQtH9YPGwAjsGGw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>, Derick Rethans <derick@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] date_diff broken?
From: rquadling@gmail.com (Richard Quadling)

On 17 June 2011 00:51, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
> I've been looking into various tests and discovered something strange in
> date_diff. Example code:
>
> <?php
> $start =3D new DateTime('2010-10-04 02:18:48 EDT');
> $end =C2=A0 =3D new DateTime('2010-11-06 18:38:28 EDT');
> $int =3D $start->diff($end);
> var_dump($start);
>
> As a result of this I'm getting this:
>
> object(DateTime)#1 (3) {
> =C2=A0["date"]=3D>
> =C2=A0string(19) "2010-10-04 06:18:48"
> =C2=A0["timezone_type"]=3D>
> =C2=A0int(2)
> =C2=A0["timezone"]=3D>
> =C2=A0string(3) "EDT"
> }
>
> As you can see, the date in $start changed, even though it shouldn't happ=
en.
> Looks like it's because of timelib_diff() which has this:
>
> =C2=A0 =C2=A0timelib_apply_localtime(one, 0);
> =C2=A0 =C2=A0timelib_apply_localtime(two, 0);
>
> which converts times in diff arguments to localtime. It then does:
>
> =C2=A0 =C2=A0timelib_apply_localtime(one, 1);
> =C2=A0 =C2=A0timelib_apply_localtime(two, 1);
>
> which is supposed to convert them back, but in fact it does not, since fi=
rst
> conversion seems to have killed TZ information. I'd propose to fix it by
> making time_diff operate on copies of one and two instead of real
> structures, but maybe somebody has a better idea?


Just ran Stas' script against a lot of 5.3's.

V5.3.0alpha2 :   string(19) "2010-10-04 06:18:48"
V5.3.0alpha3 :   string(19) "2010-10-04 06:18:48"
V5.3.0beta1 :   string(19) "2010-10-04 06:18:48"
V5.3.0RC2 :   string(19) "2010-10-04 06:18:48"
V5.3.0RC3 :   string(19) "2010-10-04 06:18:48"
V5.3.0RC4 :   string(19) "2010-10-04 06:18:48"
V5.3.0 :   string(19) "2010-10-04 06:18:48"
V5.3.1RC1 :   string(19) "2010-10-04 06:18:48"
V5.3.1RC2 :   string(19) "2010-10-04 06:18:48"
V5.3.1RC3 :   string(19) "2010-10-04 06:18:48"
V5.3.1RC4 :   string(19) "2010-10-04 06:18:48"
V5.3.1 :   string(19) "2010-10-04 06:18:48"
V5.3.2RC1 :   string(19) "2010-10-04 06:18:48"
V5.3.2RC2 :   string(19) "2010-10-04 06:18:48"
V5.3.2RC3 :   string(19) "2010-10-04 06:18:48"
V5.3.2 :   string(19) "2010-10-04 06:18:48"
V5.3.3RC1 :   string(19) "2010-10-04 06:18:48"
V5.3.3RC2 :   string(19) "2010-10-04 06:18:48"
V5.3.3RC3 :   string(19) "2010-10-04 06:18:48"
V5.3.3 :   string(19) "2010-10-04 06:18:48"
V5.3.4RC1 :   string(19) "2010-10-04 06:18:48"
V5.3.4RC2 :   string(19) "2010-10-04 06:18:48"
V5.3.4 :   string(19) "2010-10-04 06:18:48"
V5.3.5 :   string(19) "2010-10-04 06:18:48"
V5.3.6RC1 :   string(19) "2010-10-04 06:18:48"
V5.3.6RC2 :   string(19) "2010-10-04 06:18:48"
V5.3.6RC3 :   string(19) "2010-10-04 06:18:48"
V5.3.6 :   string(19) "2010-10-04 06:18:48"


Even though the behaviour is wrong, it is consistent.

There are no user notes commenting on this issue in the documentation.

Can't check the bug base at the moment due to it being down.

If either of the dates use a TLA timezone (EDT, PST, GMT), rather than
the long name (Europe/London, Indian/Kerguelen,
America/Kentucky/Louisville), then that date is altered.

Richard.

--=20
Richard Quadling
Twitter : EE : Zend : PHPDoc
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea