Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53176
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 207.97.245.133 as permitted sender)
Message-ID: <4DEE782E.1020605@sugarcrm.com>
Date: Tue, 07 Jun 2011 12:12:46 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10
MIME-Version: 1.0
To: Matthew Weier O'Phinney <weierophinney@php.net>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <BANLkTimU6DxovPQFP6cOXE0sKTDchx5Ltg@mail.gmail.com> <4DED3D5B.6030307@oracle.com> <BANLkTimEEh7eT7bH4qb9gPro_R2sKw24SyJ7JwWp8j6Ew2fH0Q@mail.gmail.com> <F8.04.15404.AAD4EED4@pb1.pair.com>
In-Reply-To: <F8.04.15404.AAD4EED4@pb1.pair.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Callable type
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> https://wiki.php.net/rfc/callable

It is good there's an RFC. However it seems to lack code examples. I 
understand it may be obvious to the proposers how it looks like, but 
it'd be nice to have the actual example there as it is done nearly 
everywhere else.

The patch introduces new zval type IS_CALLABLE but zval functions 
weren't updated for it - IIRC at least dtor may end up being called on 
IS_CALLABLE value produced in the parser.

Note also that this pseudo-type is called "callback" in all of our 
documentation, which means we have now documentation that says:

bool array_walk ( array &$array , callback $funcname [, mixed $userdata ] )

and type check that says "callable".

Also, it is not clear what would happen if this type check is made 
against method which is not accessible (e.g. private out of scope). 
Would it say that the argument is invalid (which would be really 
confusing since it'd say something like "callable expected, array given" 
which it technically correct but doesn't explain why this array is not 
callable) or would allow it? If not, then zend_is_callable error 
information should be used and displayed.
And the tests need to cover these cases, along with __call and 
__callStatic.


For me personally it makes zero sense that having just removed strict 
typing we are introducing it back through back door, but if everybody 
likes it so be it.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227