Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53085
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=SqIf7GfACRccBA4IvnbGI2RIja2fvPDxG80wogeEj8bFUmHktAwxLd3S3VvXsSCRHM
         HPaijj/Vypfc0rreBFi379RofUT7MpirJJFaT16h2QZIvbu3gf4yxBelcFlsabsLe81W
         OsH3Zkvk4BERBA+HdpBtjZlXc3NKc/LfuekuU=
MIME-Version: 1.0
In-Reply-To: <4DEC809C.5000306@zend.com>
References: <BANLkTikAcjv8ek8y-ruPCbBzrZVJ__vLHQ@mail.gmail.com> <4DEC809C.5000306@zend.com>
Date: Mon, 6 Jun 2011 18:50:13 -0300
Message-ID: <BANLkTi=VqVbRKwyHSiF7wKjG9s_EQaZ10A@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=000e0cd3098ebf84cf04a5121770
Subject: Re: [PHP-DEV] $arr = array('Hello', 'world'); $arr();
From: felipensp@gmail.com (Felipe Pena)

--000e0cd3098ebf84cf04a5121770
Content-Type: text/plain; charset=UTF-8

Hi,

2011/6/6 Dmitry Stogov <dmitry@zend.com>

> Hi Felipe,
>
> I like the idea. It makes indirect method calls less expensive.
>
> I would add a hint to specializer, to eliminate small overhead for regular
> function calls.
>
> } else if (OP1_TYPE != IS_CONST &&
>           EXPECTED(Z_TYPE_P(function_name) == IS_ARRAY) &&
>           zend_hash_num_elements(Z_ARRVAL_P(function_name)) == 2) {
>
> Thanks. Dmitry.


Dmitry:
Oh, right. I added the check for OP2_TYPE != IS_CONST, thanks for reviewing.


Christopher Jones:
Alright, I'll write a page in the wiki for the record.


All:
Committed in 5.4 and trunk now.
Thanks for the comments, folks! :)

-- 
Regards,
Felipe Pena

--000e0cd3098ebf84cf04a5121770--