Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53042
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:reply-to:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        b=xl82+KTvum1k8i7ahuLyWUzpbPTJ2k2XgVpBnNee+A6NnA3mxa8RsXwt2rXFKJPvpe
         yc8/x+W3Uq0NI2JINgrM9WZZnw9x+pKT1I4MhvstwRHbNTmjxmXNRXPLoSea644foxCl
         NWVCjtvBMnFgP8LjVkN8uqXLwnppKeShiR3tE=
MIME-Version: 1.0
Reply-To: RQuadling@GMail.com
In-Reply-To: <BANLkTi=Kbbv_Vt9zb+e3faoUqUWekDr8Gw@mail.gmail.com>
References: <BANLkTi=Kbbv_Vt9zb+e3faoUqUWekDr8Gw@mail.gmail.com>
Date: Mon, 6 Jun 2011 17:31:00 +0100
Message-ID: <BANLkTikWE4xdJs7UnX3ZfcyVO3KrxP+jLg@mail.gmail.com>
To: Arpad Ray <arraypad@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Object oriented session handlers
From: rquadling@gmail.com (Richard Quadling)

On 3 June 2011 02:18, Arpad Ray <arraypad@gmail.com> wrote:
> Hi,
>
> A while ago I submitted a patch to allow session_set_save_handler() to
> accept a class, and support the inheritance of the default session
> handler's methods.
>
> The RFC has a more detailed description and the current patch:
> https://wiki.php.net/rfc/session-oo
>
> Changes since this was last discussed:
> - More sanity checking to prevent handlers being called in unexpected states
> - ZTS fixes
>
> Any thoughts?
>
> Regards,
>
> Arpad

Not an internals expert, but I do have a question.

When would the session handler object be destroyed?

If sessions are being logged to a DB (maybe via a userland PHP class),
is internal reference counting enough to handle the order of
destruction?

If the DB connection is destroyed before the session handler gets it
destructor called (or the session_write_close equivalent), the session
won't be able to log the data and there would be no warning to the
client as engine is in auto tidy up mode.

Obviously, if the developer takes care and calls the destructors in
the right order, then everything will be OK, but this is not something
I see very often.

What about circular references and interdependent references?


-- 
Richard Quadling
Twitter : EE : Zend : PHPDoc
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea