Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53030
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=MOm5zRlDTfv13CgOqebv+k61GmIJHk9ulDa9oBqZXwkW5Ty/SA6koABWXqrhdgsMG2
         bqRD5Ujo6bZDMQ8wCM0FDKusJw/lXV6nzvpoaKQrtT+ZQ1so3v32scRH0MRVK9XcovMx
         Zh0KOV9Ro+ePkStr9WviJRKr9b1zHatx8bzq0=
MIME-Version: 1.0
In-Reply-To: <BANLkTimi+CzMENPypU3H=JDxya7dbHYmbg@mail.gmail.com>
References: <BANLkTimi+CzMENPypU3H=JDxya7dbHYmbg@mail.gmail.com>
Date: Mon, 6 Jun 2011 16:38:36 +0200
Message-ID: <BANLkTim4kqD50ed+PoA7dCTdbzkKhtKO8A@mail.gmail.com>
To: Mike Willbanks <pencap@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [Patch] GeoIP Tests
From: pierre.php@gmail.com (Pierre Joye)

hi,

please use pecl-dev to talk about pecl's packages.

Thanks for your work!

On Mon, Jun 6, 2011 at 4:37 PM, Mike Willbanks <pencap@gmail.com> wrote:
> I've gone through the GeoIP extension and ensured all of the tests now pass.
>
> Bug Report: http://pecl.php.net/bugs/bug.php?id=22749
> Patch File: http://blog.digitalstruct.com/patches/geoip-svn-tests.patch.txt
>
> Also, it looks like the GeoIP extension is based on an extremely old
> version, I am going to start looking to update this to get all of the new
> constants that should exist into the extension.
> A slight amount of behavior changed and should have been noted previously
> for the test as "CA" is no longer a valid country code w/o a region in the
> timeZone.c area of the GeoIP C API.
>
> Someone with karma want to review and apply the patch for the tests?
>
> Regards,
>
> Mike
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org