Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:53029
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=t6KUFkhs1Qm7bvokzyKXYMo6b8mX0S4RUsfvLSYqckkfMwktIxntoZP8NV/212sBIT
         vE6rPTqyUuiTxpE7b4HiLe5pHYq6iFg8GlU5FUyC91CAmwzEGMQIPaCSkzzgqeVxJ9EU
         l9N/u5EWPQo7wt05JlVkw3EVuM/K+6dyiRelM=
MIME-Version: 1.0
Date: Mon, 6 Jun 2011 09:37:09 -0500
Message-ID: <BANLkTimi+CzMENPypU3H=JDxya7dbHYmbg@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec5016663d2c19604a50c09c6
Subject: [Patch] GeoIP Tests
From: pencap@gmail.com (Mike Willbanks)

--bcaec5016663d2c19604a50c09c6
Content-Type: text/plain; charset=UTF-8

I've gone through the GeoIP extension and ensured all of the tests now pass.

Bug Report: http://pecl.php.net/bugs/bug.php?id=22749
Patch File: http://blog.digitalstruct.com/patches/geoip-svn-tests.patch.txt

Also, it looks like the GeoIP extension is based on an extremely old
version, I am going to start looking to update this to get all of the new
constants that should exist into the extension.
A slight amount of behavior changed and should have been noted previously
for the test as "CA" is no longer a valid country code w/o a region in the
timeZone.c area of the GeoIP C API.

Someone with karma want to review and apply the patch for the tests?

Regards,

Mike

--bcaec5016663d2c19604a50c09c6--