Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52956
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=pRdZ57Gm5tkPO2/pZN6HLeI4uq/rdP9tHTZktxA/v1/q8ek9Yuh6cqOjg02BeKdMxs
         235+XYJTjMdQ+RaS9k9VP0TCuc7M6BCRXgE4XpVMvHvt1QlJ+2j+niv9vwa8IPa5aE5W
         Q9bgySMgyvub1ca/MwgdRsxL3D46a0Q8+LH7Y=
MIME-Version: 1.0
In-Reply-To: <BANLkTimr_Wmn5rdF4hhAbwBhc_k=m8Tmxw@mail.gmail.com>
References: <4DEB3D65.107@sugarcrm.com>
	<BANLkTinyD_EmnnOvZP_oS9K19fBq4Q8ROA@mail.gmail.com>
	<BANLkTi=2Qg=NHeXyovvty-guUCzHHfo5sQ@mail.gmail.com>
	<4DEBD46E.3070708@sugarcrm.com>
	<BANLkTimr_Wmn5rdF4hhAbwBhc_k=m8Tmxw@mail.gmail.com>
Date: Sun, 5 Jun 2011 21:18:37 +0200
Message-ID: <BANLkTikQpiwTaCHQrXCbtk0cwcq8PyuRDA@mail.gmail.com>
To: Felipe Pena <felipensp@gmail.com>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] bug #39863 in trunk/5.4
From: pierre.php@gmail.com (Pierre Joye)

On Sun, Jun 5, 2011 at 9:13 PM, Felipe Pena <felipensp@gmail.com> wrote:
> 2011/6/5 Stas Malyshev <smalyshev@sugarcrm.com>
>>
>> Hi!
>>
>>> Should http://felipe.ath.cx/diff/parse_arg_null_path.diff be enough
>>> (beyond changing others function parse args, fixing the tests,
>>> include+require part)?
>>>
>>> $ sapi/cli/php -r 'fopen("a\0b", "r");'
>>>
>>> Warning: fopen() expects parameter 1 to be valid path, string given in
>>> Command line code on line 1
>>
>> This should be applied not only to fopen but to any function that does
>> anything with filenames (and include/require/etc. also, I guess).
>>
>
> Of course, I was just checking if it's what you guys are thinking first.

yes, that's the idea, to add a argument for zend_parse and a
function/macro for other areas.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org