Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52948 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13676 invoked from network); 5 Jun 2011 17:09:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Jun 2011 17:09:37 -0000 Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.173 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 209.85.212.173 mail-px0-f173.google.com Received: from [209.85.212.173] ([209.85.212.173:57357] helo=mail-px0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D5/93-26000-158BBED4 for ; Sun, 05 Jun 2011 13:09:37 -0400 Received: by pxi16 with SMTP id 16so2033354pxi.18 for ; Sun, 05 Jun 2011 10:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=X9KltpWkxRqo+FBiimKB7zZYPzzb2z3sKiYYvtI5ulg=; b=OPRuTaUh7jpDvUyUkYjqKuLvcerm5s2uMSfDW1ZnjzyaEC3VAvhpncEekPGiKnCldn eDjeLmUgg90yac+2EEpSg25Jb5CRE5FShloXMDjRF7HxP83jNRssxLfx+aQOK0yqUaol 8Q7Nlrh+Jgoteiqsjpas/ztIBUp+e7QrcKB1g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=gqiCl8GtbHKppYTO4+FCmLFBzgRcJO8mBph3re7h9TVt9N+rhHqT5F7khjQ40i9/CZ h4T3vCPCQEldz+eEhVtLvyM3QZBBVLzbjl7+BIdybzq8ICyKJuu2689oh1An5RmuOUgS aNYNqL3ONktSLJ1jRHli9Jua0DxmB9JgB3bU0= Received: by 10.142.147.19 with SMTP id u19mr636117wfd.119.1307293774270; Sun, 05 Jun 2011 10:09:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.246.21 with HTTP; Sun, 5 Jun 2011 10:09:14 -0700 (PDT) In-Reply-To: References: <4DE80C77.1010109@no-surprises.co.uk> Date: Sun, 5 Jun 2011 14:09:14 -0300 Message-ID: To: Ilia Alshanetsky Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary=000e0cd3098e08522004a4fa0d50 Subject: Re: [PHP-DEV] RFC: Zend Signal Handling From: felipensp@gmail.com (Felipe Pena) --000e0cd3098e08522004a4fa0d50 Content-Type: text/plain; charset=UTF-8 Fixed crash in fastcgi due startup order... SIGG() were being used before tsrm_startup(). 2011/6/4 Felipe Pena > Fixed invalid sigaction() call passing NSIG as signal number. > > - for (signo = 1; signo <= NSIG; ++signo) { > + for (signo = 1; signo < NSIG; ++signo) { > > Detected by Valgrind: > ==4577== Warning: bad signal number 65 in sigaction() > > > 2011/6/3 Ilia Alshanetsky > >> The crash is now fixed as well. >> >> On Fri, Jun 3, 2011 at 2:41 AM, Felipe Pena wrote: >> > 2011/6/2 Felipe Pena >> > >> >> Hi, >> >> >> >> 2011/6/2 Michael Maclean >> >> >> >>> On 02/06/11 18:20, Gustavo Lopes wrote: >> >>> >> >>>> Em Thu, 02 Jun 2011 18:10:50 +0100, Ilia Alshanetsky < >> ilia@prohost.org> >> >>>> escreveu: >> >>>> >> >>>> Killing TSRMLS_FETCH is a noble goal, but let's keep it to once >> patch >> >>>>> at a time please ;-) And for the record I am all for killing >> >>>>> TSRMLS_FETCH. >> >>>>> >> >>>>> >> >>>> Is there any advantage in killing it as opposed to simply not use it? >> >>>> >> >>> >> >>> I think he meant just replacing it in this patch. >> >>> >> >>> >> >> Just to inform, with the patched applied in trunk we have 4 SIGSEGVs >> with >> >> ext/pcntl tests: >> >> >> >> pcntl_alarm() [ext/pcntl/tests/pcntl_alarm.phpt] >> >> pcntl_signal() [ext/pcntl/tests/pcntl_signal.phpt] >> >> pcnt_signal_dispatch() [ext/pcntl/tests/pcntl_signal_dispatch.phpt] >> >> Closures as a signal handler >> [ext/pcntl/tests/signal_closure_handler.phpt] >> >> >> >> And 1 test hanging: >> >> ext/pcntl/tests/002.phpt >> >> >> > >> > >> > Ok, already fixed. There is only a test failing due a behavior change: >> > >> > $ cat ext/pcntl/tests/pcntl_signal.diff >> > 009+ Fatal error: Error installing signal handler for -1 in >> > /home/felipe/dev/phptrunk/ext/pcntl/tests/pcntl_signal.php on line 10 >> > 009- Warning: pcntl_signal(): Error assigning signal %s >> > 010- bool(false) >> > 011- >> > 012- Warning: pcntl_signal(): Error assigning signal %s >> > 013- bool(false) >> > 014- >> > 015- Warning: pcntl_signal(): not callable is not a callable function >> name >> > error in %s >> > 016- bool(false) >> > 017- ok >> > >> > -- >> > Regards, >> > Felipe Pena >> > >> > > > > -- > Regards, > Felipe Pena > -- Regards, Felipe Pena --000e0cd3098e08522004a4fa0d50--