Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52907
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=njjId40eAlVWQEbNCR4W8WH4vHfWcJ3B0FSHbQyvGxHsqDxANmIGp6vupnFZKsYv0R
         HJq/ICqllMMUlwERe98Lu2pr44ZRf5CsIJZ8ouNzkFxy9GnUkaigRh0CacE2Zb4nzpjk
         fLPwxLknJe4hASL7TFTGIu4KIJnag6MUAaU8c=
MIME-Version: 1.0
In-Reply-To: <BANLkTinkT6uGtjJ2fvsaorg1Zo1ZzxqMqw@mail.gmail.com>
References: <BANLkTimX=veOA+yStHA+eQA4pyWNTAeeWg@mail.gmail.com>
 <BANLkTi=MS9oebW9X5_RQLZnAWn89Y9YWWQ@mail.gmail.com> <BANLkTikuKHiCWauSULjOf9XP22pPf1fMnw@mail.gmail.com>
 <op.vwgk41uyidpuyk@clk-0081.clk-domain> <4DE80C77.1010109@no-surprises.co.uk>
 <BANLkTi==XW90MvKDA_c8N3n9TGRsLR3XAA@mail.gmail.com> <BANLkTi=gaK0VgURRydAHaOtdrTm9eQAAXQ@mail.gmail.com>
 <BANLkTinkT6uGtjJ2fvsaorg1Zo1ZzxqMqw@mail.gmail.com>
Date: Sat, 4 Jun 2011 22:17:58 -0300
Message-ID: <BANLkTikn4FaXF5RemjBGqaYzJf_zPmw9kg@mail.gmail.com>
To: Ilia Alshanetsky <ilia@prohost.org>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=00504502cb1607953504a4ecc3f3
Subject: Re: [PHP-DEV] RFC: Zend Signal Handling
From: felipensp@gmail.com (Felipe Pena)

--00504502cb1607953504a4ecc3f3
Content-Type: text/plain; charset=UTF-8

Fixed invalid sigaction() call passing NSIG as signal number.

- for (signo = 1; signo <= NSIG; ++signo) {
+ for (signo = 1; signo < NSIG; ++signo) {

Detected by Valgrind:
==4577== Warning: bad signal number 65 in sigaction()


2011/6/3 Ilia Alshanetsky <ilia@prohost.org>

> The crash is now fixed as well.
>
> On Fri, Jun 3, 2011 at 2:41 AM, Felipe Pena <felipensp@gmail.com> wrote:
> > 2011/6/2 Felipe Pena <felipensp@gmail.com>
> >
> >> Hi,
> >>
> >> 2011/6/2 Michael Maclean <michael@no-surprises.co.uk>
> >>
> >>> On 02/06/11 18:20, Gustavo Lopes wrote:
> >>>
> >>>> Em Thu, 02 Jun 2011 18:10:50 +0100, Ilia Alshanetsky <
> ilia@prohost.org>
> >>>> escreveu:
> >>>>
> >>>>  Killing TSRMLS_FETCH is a noble goal, but let's keep it to once patch
> >>>>> at a time please ;-) And for the record I am all for killing
> >>>>> TSRMLS_FETCH.
> >>>>>
> >>>>>
> >>>> Is there any advantage in killing it as opposed to simply not use it?
> >>>>
> >>>
> >>> I think he meant just replacing it in this patch.
> >>>
> >>>
> >> Just to inform, with the patched applied in trunk we have 4 SIGSEGVs
> with
> >> ext/pcntl tests:
> >>
> >> pcntl_alarm() [ext/pcntl/tests/pcntl_alarm.phpt]
> >> pcntl_signal() [ext/pcntl/tests/pcntl_signal.phpt]
> >> pcnt_signal_dispatch() [ext/pcntl/tests/pcntl_signal_dispatch.phpt]
> >> Closures as a signal handler
> [ext/pcntl/tests/signal_closure_handler.phpt]
> >>
> >> And 1 test hanging:
> >> ext/pcntl/tests/002.phpt
> >>
> >
> >
> > Ok, already fixed. There is only a test failing due a behavior change:
> >
> > $ cat ext/pcntl/tests/pcntl_signal.diff
> > 009+ Fatal error: Error installing signal handler for -1 in
> > /home/felipe/dev/phptrunk/ext/pcntl/tests/pcntl_signal.php on line 10
> > 009- Warning: pcntl_signal(): Error assigning signal %s
> > 010- bool(false)
> > 011-
> > 012- Warning: pcntl_signal(): Error assigning signal %s
> > 013- bool(false)
> > 014-
> > 015- Warning: pcntl_signal(): not callable is not a callable function
> name
> > error in %s
> > 016- bool(false)
> > 017- ok
> >
> > --
> > Regards,
> > Felipe Pena
> >
>



-- 
Regards,
Felipe Pena

--00504502cb1607953504a4ecc3f3--