Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52866 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4649 invoked from network); 3 Jun 2011 17:22:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jun 2011 17:22:40 -0000 Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain prohost.org designates 209.85.214.42 as permitted sender) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.214.42 mail-bw0-f42.google.com Received: from [209.85.214.42] ([209.85.214.42:53271] helo=mail-bw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 98/C7-08509-E5819ED4 for ; Fri, 03 Jun 2011 13:22:39 -0400 Received: by bwz18 with SMTP id 18so2206882bwz.29 for ; Fri, 03 Jun 2011 10:22:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.7.74 with SMTP id c10mr2229615bkc.104.1307121755834; Fri, 03 Jun 2011 10:22:35 -0700 (PDT) Received: by 10.204.72.3 with HTTP; Fri, 3 Jun 2011 10:22:35 -0700 (PDT) In-Reply-To: References: <4DE80C77.1010109@no-surprises.co.uk> Date: Fri, 3 Jun 2011 19:22:35 +0200 Message-ID: To: Felipe Pena Cc: Michael Maclean , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] RFC: Zend Signal Handling From: ilia@prohost.org (Ilia Alshanetsky) The crash is now fixed as well. On Fri, Jun 3, 2011 at 2:41 AM, Felipe Pena wrote: > 2011/6/2 Felipe Pena > >> Hi, >> >> 2011/6/2 Michael Maclean >> >>> On 02/06/11 18:20, Gustavo Lopes wrote: >>> >>>> Em Thu, 02 Jun 2011 18:10:50 +0100, Ilia Alshanetsky >>>> escreveu: >>>> >>>> =A0Killing TSRMLS_FETCH is a noble goal, but let's keep it to once pat= ch >>>>> at a time please ;-) And for the record I am all for killing >>>>> TSRMLS_FETCH. >>>>> >>>>> >>>> Is there any advantage in killing it as opposed to simply not use it? >>>> >>> >>> I think he meant just replacing it in this patch. >>> >>> >> Just to inform, with the patched applied in trunk we have 4 SIGSEGVs wit= h >> ext/pcntl tests: >> >> pcntl_alarm() [ext/pcntl/tests/pcntl_alarm.phpt] >> pcntl_signal() [ext/pcntl/tests/pcntl_signal.phpt] >> pcnt_signal_dispatch() [ext/pcntl/tests/pcntl_signal_dispatch.phpt] >> Closures as a signal handler [ext/pcntl/tests/signal_closure_handler.php= t] >> >> And 1 test hanging: >> ext/pcntl/tests/002.phpt >> > > > Ok, already fixed. There is only a test failing due a behavior change: > > $ cat ext/pcntl/tests/pcntl_signal.diff > 009+ Fatal error: Error installing signal handler for -1 in > /home/felipe/dev/phptrunk/ext/pcntl/tests/pcntl_signal.php on line 10 > 009- Warning: pcntl_signal(): Error assigning signal %s > 010- bool(false) > 011- > 012- Warning: pcntl_signal(): Error assigning signal %s > 013- bool(false) > 014- > 015- Warning: pcntl_signal(): not callable is not a callable function nam= e > error in %s > 016- bool(false) > 017- ok > > -- > Regards, > Felipe Pena >