Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52828 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80091 invoked from network); 3 Jun 2011 00:42:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jun 2011 00:42:14 -0000 Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.173 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 209.85.212.173 mail-px0-f173.google.com Received: from [209.85.212.173] ([209.85.212.173:33585] helo=mail-px0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AB/10-12176-4ED28ED4 for ; Thu, 02 Jun 2011 20:42:13 -0400 Received: by pxi16 with SMTP id 16so818700pxi.18 for ; Thu, 02 Jun 2011 17:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=IMNf5vdzQpEhmDb9c9nlQe3J/1FTaGFq3jEWtcWUU5w=; b=lfdVH0sG2jiSbm0ZbkJ4EAlHmkH6nDfYeYcjDq+e1WhEfdJagD+TGmDibaz+YEQItP 4Vj7T66UB7VetFvlDfDv1BuheQiD09xQpozm+DLjzAaFRzflt2MeuQvT4E+DBaIxYPv0 8bFtdZKXIZq59gAClbRYJXswPywfygv+6YB9c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=FULoEAUlbk28JqPUxLGSmlOUqZXoyOi7vMCAepC2OZxqZKdJunesxOe1702OlMQ10U 35DGC3KxJZUDiiOt26LrzMVZzvzzHJiXy+IWqYfFHAJq+85jIM+HzmlWVFk6haRNcVR8 W7AHEOVucZOjogJkK9FNzedXhx+rXd2iKuGPk= Received: by 10.143.26.26 with SMTP id d26mr228090wfj.176.1307061729271; Thu, 02 Jun 2011 17:42:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.246.21 with HTTP; Thu, 2 Jun 2011 17:41:49 -0700 (PDT) In-Reply-To: References: <4DE80C77.1010109@no-surprises.co.uk> Date: Thu, 2 Jun 2011 21:41:49 -0300 Message-ID: To: Michael Maclean Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary=001636e0ae0d129e2f04a4c406af Subject: Re: [PHP-DEV] RFC: Zend Signal Handling From: felipensp@gmail.com (Felipe Pena) --001636e0ae0d129e2f04a4c406af Content-Type: text/plain; charset=UTF-8 2011/6/2 Felipe Pena > Hi, > > 2011/6/2 Michael Maclean > >> On 02/06/11 18:20, Gustavo Lopes wrote: >> >>> Em Thu, 02 Jun 2011 18:10:50 +0100, Ilia Alshanetsky >>> escreveu: >>> >>> Killing TSRMLS_FETCH is a noble goal, but let's keep it to once patch >>>> at a time please ;-) And for the record I am all for killing >>>> TSRMLS_FETCH. >>>> >>>> >>> Is there any advantage in killing it as opposed to simply not use it? >>> >> >> I think he meant just replacing it in this patch. >> >> > Just to inform, with the patched applied in trunk we have 4 SIGSEGVs with > ext/pcntl tests: > > pcntl_alarm() [ext/pcntl/tests/pcntl_alarm.phpt] > pcntl_signal() [ext/pcntl/tests/pcntl_signal.phpt] > pcnt_signal_dispatch() [ext/pcntl/tests/pcntl_signal_dispatch.phpt] > Closures as a signal handler [ext/pcntl/tests/signal_closure_handler.phpt] > > And 1 test hanging: > ext/pcntl/tests/002.phpt > Ok, already fixed. There is only a test failing due a behavior change: $ cat ext/pcntl/tests/pcntl_signal.diff 009+ Fatal error: Error installing signal handler for -1 in /home/felipe/dev/phptrunk/ext/pcntl/tests/pcntl_signal.php on line 10 009- Warning: pcntl_signal(): Error assigning signal %s 010- bool(false) 011- 012- Warning: pcntl_signal(): Error assigning signal %s 013- bool(false) 014- 015- Warning: pcntl_signal(): not callable is not a callable function name error in %s 016- bool(false) 017- ok -- Regards, Felipe Pena --001636e0ae0d129e2f04a4c406af--