Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52476
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=v+DcjjiibSWJ4G4Hkoa0a8m/U2yBflD0+dXs4rYcjdX9jZVRZefrchU6xuD4E0sO74
         Sry3IjQJ46SQePm+tBB5JKOIETQyXsMNcs8olQmDFFAXZNcBY5G2PiFGNp8BIZ6mRN3M
         vlKkb5yvXSkk6CszPtcq3YLanv6hSvg4dsGwI=
MIME-Version: 1.0
In-Reply-To: <4DD64514.3070108@zend.com>
References: <4DD63451.10408@zend.com>
	<BANLkTin5L8AuzS+oaJU2fb371iDi2JX5KQ@mail.gmail.com>
	<4DD63C03.3090401@zend.com>
	<BANLkTikgDnDHoVtajtSBcY_iakckVQrebg@mail.gmail.com>
	<4DD64514.3070108@zend.com>
Date: Fri, 20 May 2011 12:45:56 +0200
Message-ID: <BANLkTi=+qmc5g6kCJC8VyoA3RQN8d5xpUQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP Internals <internals@lists.php.net>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Andi Gutmans <andi@zend.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] arithmetic speedup
From: pierre.php@gmail.com (Pierre Joye)

On Fri, May 20, 2011 at 12:40 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> On 05/20/2011 02:05 PM, Pierre Joye wrote:
>>
>> On Fri, May 20, 2011 at 12:01 PM, Dmitry Stogov<dmitry@zend.com> =A0wrot=
e:
>>>
>>> Hi Pierre,
>>>
>>> On 05/20/2011 01:49 PM, Pierre Joye wrote:
>>>>
>>>> hi Dmitry,
>>>>
>>>> Nice improvements, thanks :)
>>>>
>>>> Any reason not to have done the changes for windows as well?
>>>
>>> Sorry, I'm not an expert in MS VC inline assembler.
>>> As I remember in VC6 it was poor and didn't allow complicated things.
>>> In case someone can add support for VC it would be great.
>>>
>>>> What's about putting the asm code in external file so it can used by
>>>> more compilers? (some has issues with inline asm, like VC in x64 mode,
>>>> other may have as well afair).
>>>
>>> The main idea of the patch is inlining and I don't know how can I inlin=
e
>>> from external file.
>>>
>>> In simple cases the function call, parameter passing, prologue, epilogu=
e
>>> make more overhead than the opration itself. So the inlining is
>>> responsable
>>> for 90% of speedup while asm optimization only for 10%.
>>>
>>> Thanks. Dmitry.
>>
>> As this patch is only GCC (and linux I suppose),
>
> The inlining must be done on all platforms so it should affect Windows to=
o.

It could be inlined and externalized, the only issue is about compiler
and inline assemblers. Will test.

>> I would suggest to
>> simply commit in trunk right now. Other platforms can implement it
>> later (I will do it for windows in the next weeks).
>
> I'll commit on Monday.

Thanks!

--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org