Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52441 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96389 invoked from network); 18 May 2011 08:42:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 May 2011 08:42:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=glopes@nebm.ist.utl.pt; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=glopes@nebm.ist.utl.pt; sender-id=unknown Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error) X-PHP-List-Original-Sender: glopes@nebm.ist.utl.pt X-Host-Fingerprint: 193.136.128.21 smtp1.ist.utl.pt Linux 2.6 Received: from [193.136.128.21] ([193.136.128.21:48696] helo=smtp1.ist.utl.pt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B7/10-30014-46683DD4 for ; Wed, 18 May 2011 04:42:15 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.ist.utl.pt (Postfix) with ESMTP id A0D657000443 for ; Wed, 18 May 2011 09:42:08 +0100 (WEST) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at ist.utl.pt Received: from smtp1.ist.utl.pt ([127.0.0.1]) by localhost (smtp1.ist.utl.pt [127.0.0.1]) (amavisd-new, port 10025) with LMTP id NVGOb8mb8Hau for ; Wed, 18 May 2011 09:42:08 +0100 (WEST) Received: from mail2.ist.utl.pt (mail2.ist.utl.pt [193.136.128.12]) by smtp1.ist.utl.pt (Postfix) with ESMTP id 6A8D07000424 for ; Wed, 18 May 2011 09:42:08 +0100 (WEST) Received: from clk-0081.clk-domain (unknown [85.139.253.17]) (Authenticated sender: ist155741) by mail2.ist.utl.pt (Postfix) with ESMTPSA id 1EDA6200738C for ; Wed, 18 May 2011 09:42:08 +0100 (WEST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: internals@lists.php.net References: <887FE7CFF6F8DE4BB3A9535F53AFD06A492D09D2@il-ex2.zend.net> <4DD2A731.9000400@sugarcrm.com> Date: Wed, 18 May 2011 09:42:07 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?= =?utf-8?Q?ca_do_I=2ES=2ET=2E?= Message-ID: In-Reply-To: <4DD2A731.9000400@sugarcrm.com> User-Agent: Opera Mail/11.10 (Win32) Subject: Re: [PHP-DEV] Re: [RFC] Improved parser error message From: glopes@nebm.ist.utl.pt ("Gustavo Lopes") Em Tue, 17 May 2011 17:49:53 +0100, Stas Malyshev escreveu: > I think we need to keep token name in the message, since it makes it > easier to understand what parser expected if you need to debug the > parser (as opposed to your code). So I think we need to have both the > human-readable name and the token name, as Andi suggested. I think this alternative has very little value for debugging the parser. There are no repeated labels for the tokens, so even if you don't know the token name by heart, you can look it up in 10 seconds. Keeping the token name will only perpetuate the confusion it has caused. I think it ought to be dropped, but if no consensus can be reached, this would be better than the status quo. -- Gustavo Lopes